MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002350VCMIAI - Adventure Mappublic2015-12-15 10:252022-04-12 11:04
ReporterSXX 
Assigned ToSXX 
PrioritynormalSeveritycrashReproducibilityrandom
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version0.98e 
Target VersionFixed in Version0.99 
Summary0002350: AI may sometimes attempt to visit invalid boat object
DescriptionProblem occur that for some reason "validateVisitableObjs" called from VCAI::getPossibleDestinations don't remove boat object as it's kind a valid even if it's position completely messed up.

I'm attempted to reproduce it myself with normal client, but wasn't successful yet. E.g I have feeling that problem may occur because when hero in boat killed only "objectRemoved" for hero only getting sent, but that not explain why validateVisitableObjs not remove it as it's shouldn't be in gamestate anyway.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0002158closed AVS I can't load save 
Attached Filestxt crash_11111.txt (1,970) 2015-12-16 22:39
https://bugs.vcmi.eu/file_download.php?file_id=2403&type=bug
txt crash_11112.txt (2,492) 2015-12-16 22:44
https://bugs.vcmi.eu/file_download.php?file_id=2404&type=bug
7z CRASH_SAVE_noncopyableBonusSystemNode.7z (1,434,185) 2015-12-16 22:45
https://bugs.vcmi.eu/file_download.php?file_id=2405&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-12-15 10:25SXXNew Issue
2015-12-15 10:25SXXStatusnew => assigned
2015-12-15 10:25SXXAssigned To => Warmonger
2015-12-16 22:39SXXFile Added: crash_11111.txt
2015-12-16 22:41SXXNote Added: 0006180
2015-12-16 22:43SXXNote Added: 0006181
2015-12-16 22:44SXXFile Added: crash_11112.txt
2015-12-16 22:45SXXFile Added: CRASH_SAVE_noncopyableBonusSystemNode.7z
2015-12-16 22:47SXXNote Added: 0006182
2016-01-14 06:11SXXRelationship addedrelated to 0002374
2016-01-14 06:16SXXAssigned ToWarmonger => SXX
2016-01-19 22:07SXXRelationship deletedrelated to 0002374
2016-09-04 12:50SXXNote Added: 0006618
2016-09-04 12:50SXXStatusassigned => resolved
2016-09-04 12:50SXXFixed in Version => 0.99
2016-09-04 12:50SXXResolutionopen => fixed
2016-09-12 02:47SXXRelationship addedrelated to 0002158
2022-04-12 11:04PovelitelStatusresolved => closed

Notes
(0006180)
SXX   
2015-12-16 22:41   
So here is trace of that crash in "crash_11111.txt". It's for teleporter, but as far as I can tell what happen with boat is exactly same issue.

Also it's end up that first time when issue occur game crash on AI turn, but often when loading from save game start to crash on save serialization after AI turn is finished. Ivan also confirmed that saves get's corrupted.
(0006181)
SXX   
2015-12-16 22:43   
Just in case these crashes occur with "noncopyableBonusSystemNode" branch:
https://github.com/vcmi/vcmi/pull/148 [^]
So it's not simply issue related to bonuses, but there is likely something wrong happen in serialization or AI.
(0006182)
SXX   
2015-12-16 22:47   
Also I do have save files for these crashes, but they're only for noncopyableBonusSystemNode branch for commit d2341b9745eee9e271885a2524f6a12bde817e0d. It's also recommended to merge develop into it at least up to commit 9490a5d66d3d2506948521ffe91d6b844c254320.

Uploaded "CRASH_SAVE_noncopyableBonusSystemNode.7z".
(0006618)
SXX   
2016-09-04 12:50   
Should be now fixed:

https://github.com/vcmi/vcmi/commit/8e94b1c4d2f8b707dbbc50b9849cbdf2b3a3f901 [^]