MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000232VCMIMechanics - Town structurespublic2009-11-28 03:492014-05-30 17:39
ReporterZamolxis 
Assigned ToTow 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version0.74c 
Target VersionFixed in Version0.82 
Summary0000232: All Tavern heroes come with full armies (also after the first two heroes were hired)
DescriptionAll heroes come now at Tavern with full armies.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0000025closed Tow Tavern hero with only 1 L.1 creature at week start (0.71#70) 
has duplicate 0000239closed Warmonger All heroes available for hire in the town Tavern have full starting armies. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-11-28 03:49ZamolxisNew Issue
2009-11-28 11:29ZamolxisSummaryTavern gives heroes with full armies also after the first two heroes were hired. => All Tavern heroes come with full armies (also after the first two heroes were hired)
2009-11-28 11:29ZamolxisRelationship addedhas duplicate 0000239
2009-11-28 11:30ZamolxisStatusnew => assigned
2009-11-28 11:30ZamolxisAssigned To => Warmonger
2009-11-28 11:31ZamolxisRelationship addedrelated to 0000025
2010-06-25 11:20BoulieNote Added: 0000972
2010-06-25 11:21BoulieNote Edited: 0000972bug_revision_view_page.php?bugnote_id=972#r897
2010-07-08 05:53TowNote Added: 0001044
2010-07-08 05:53TowStatusassigned => resolved
2010-07-08 05:53TowFixed in Version => 0.89
2010-07-08 05:53TowResolutionopen => fixed
2010-07-08 05:53TowAssigned ToWarmonger => Tow
2010-07-26 13:10BoulieNote Added: 0001166
2010-07-26 21:01TowNote Added: 0001179
2010-07-26 21:05TowNote Added: 0001180
2010-07-26 22:29BoulieNote Added: 0001182
2014-05-30 17:39beegeeStatusresolved => closed

Notes
(0000972)
Boulie   
2010-06-25 11:20   
(edited on: 2010-06-25 11:21)
Just to point how it should be:

Heroes' starting troops:
The probability of heroes starting (or appearing in Tavern) with only 1 stack is 9%, with 2 its 69%, with 3 its 22%.
Level 1 unit specialists will only start with level 1 units.
Level 2 unit specialists will only start with level 2 units.
Level 3 unit specialists may start with level 1 and level 3 units.
Heroes having the possibility to start with a War Machine will not start with level 2 units.
(0001044)
Tow   
2010-07-08 05:53   
Fixed in r1637
(0001166)
Boulie   
2010-07-26 13:10   
For sure the probability is wrong. Really rare heroes have only 2 stacks.
Wasn't mentioned above - Bron should start with basilisks like lvl 3 units specialists.

Lvl 1 units spec - ok.
Lvl 2 units spec - ok
Lvl 3 units spec - ok
War mach spec - ok
(0001179)
Tow   
2010-07-26 21:01   
True, my mistake - it always generated full possible army. R1692 should fix it.
(0001180)
Tow   
2010-07-26 21:05   
As for the Bron I'm confused. OH3 indeed gives him Basilisks in starting army. However HOTRAITS.TXT which describes heroes starting army has entry:
Bron 10 20 Gnoll 4 7 PrimitiveLizardman 2 4 SerpentFly

VCMI gets information about starting armies from that file and there is no mention of basilisks.
The issue probably should be solved by adjusting HOTRAITS to describe the real behaviour of OH3 (did they hardcode Bron's basilisks?).
(0001182)
Boulie   
2010-07-26 22:29   
I've not being thinking too much about this before. My previous info was also wrong cause Bron isn't like lvl 3 units specialist. Only Lizards are replaced by Basilisks. Serpent files not.
HoTraits is not changing type of creature only can change quantity. So type is coded in other file or is hardcoded. I've just made few tests with it.
Probably nothing more I can think up about it.