MantisBT - VCMI
View Issue Details
0002316VCMIMechanics - Otherpublic2015-10-24 23:342016-11-11 07:43
Povelitel 
SXX 
normalcrashalways
closedunable to reproduce 
0.98d 
0.99 
0002316: Unique: Crash during AI turn (Bonus::DISGUISED check)
Client crash, server crash
No tags attached.
related to 0002314resolved AVS Crashes related to bonus system in deserializationFix 
rar Saves.rar (1,521,880) 2015-10-24 23:34
https://bugs.vcmi.eu/file_download.php?file_id=2378&type=bug
txt VCMI_Client_log.txt (2,261,506) 2015-10-24 23:34
https://bugs.vcmi.eu/file_download.php?file_id=2379&type=bug
txt VCMI_Server_log.txt (994,927) 2015-10-24 23:34
https://bugs.vcmi.eu/file_download.php?file_id=2380&type=bug
Issue History
2015-10-24 23:34PovelitelNew Issue
2015-10-24 23:34PovelitelStatusnew => assigned
2015-10-24 23:34PovelitelAssigned To => Warmonger
2015-10-24 23:34PovelitelFile Added: Saves.rar
2015-10-24 23:34PovelitelFile Added: VCMI_Client_log.txt
2015-10-24 23:34PovelitelFile Added: VCMI_Server_log.txt
2015-10-25 07:50WarmongerNote Added: 0006004
2015-10-25 11:19PovelitelNote Added: 0006019
2015-10-25 17:05PovelitelRelationship addedrelated to 0002318
2015-10-25 18:01WarmongerNote Added: 0006023
2015-10-25 18:05WarmongerNote Added: 0006024
2015-10-25 18:06WarmongerAssigned ToWarmonger =>
2015-10-25 18:06WarmongerStatusassigned => new
2015-10-25 18:06WarmongerCategoryAI - Adventure Map => Mechanics - Other
2015-10-25 18:13WarmongerRelationship addedrelated to 0002315
2015-12-11 20:57SXXRelationship addedrelated to 0002314
2015-12-14 06:04SXXRelationship deletedrelated to 0002314
2015-12-14 06:04SXXAssigned To => AVS
2015-12-14 06:04SXXStatusnew => assigned
2015-12-14 06:05SXXNote Added: 0006178
2015-12-14 06:06SXXNote Edited: 0006178bug_revision_view_page.php?bugnote_id=6178#r3062
2015-12-25 12:15SXXRelationship deletedrelated to 0002315
2015-12-25 12:16SXXSummaryCrash during AI turn => Crash during AI turn (Bonus::DISGUISED check)
2015-12-25 12:20SXXRelationship deletedrelated to 0002318
2015-12-25 12:22SXXSummaryCrash during AI turn (Bonus::DISGUISED check) => Unique: Crash during AI turn (Bonus::DISGUISED check)
2015-12-25 12:22SXXNote Added: 0006235
2016-09-04 08:19SXXRelationship addedrelated to 0002314
2016-09-04 08:20SXXNote Added: 0006616
2016-09-04 08:20SXXStatusassigned => resolved
2016-09-04 08:20SXXFixed in Version => 0.99
2016-09-04 08:20SXXResolutionopen => unable to reproduce
2016-09-04 08:20SXXAssigned ToAVS => SXX
2016-11-11 07:43PovelitelStatusresolved => closed

Notes
(0006004)
Warmonger   
2015-10-25 07:50   
Can't load :(
(0006019)
Povelitel   
2015-10-25 11:19   
The same is true of the 2308 saves as I loaded ...
(0006023)
Warmonger   
2015-10-25 18:01   
OK works now.
(0006024)
Warmonger   
2015-10-25 18:05   
Crash is related to bugged Bonus at DISGUISE check:

int disguiseLevel = h->valOfBonuses(Selector::typeSubtype(Bonus::DISGUISED, 0));

in CGameInfoCallback.cpp, line 267

Debugger actually points at

int decision = b->limiter ? b->limiter->limit(context) : ILimiter::ACCEPT;

in HeroBonus.cpp, line 1042

So probably it's not AI bug.
(0006178)
SXX   
2015-12-14 06:05   
(edited on: 2015-12-14 06:06)
BTW @AVS you may want to look at this one.
It's the only bonus-related crash I managed to get in noncopyableBonusSystemNode branch:
https://github.com/vcmi/vcmi/pull/148 [^]

Though I have no idea if it's related or not. Anyway it's related to spell implementation at least. :-)

(0006235)
SXX   
2015-12-25 12:22   
So basically this is the only crash that not really fixed by noncopyableBonusSystemNode.
All other are fixed by branch.
(0006616)
SXX   
2016-09-04 08:20   
I'll pretend this one was still related to 0002314.
So not reproducible anymore.