MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002264VCMIMechanics - Objectspublic2015-10-01 20:392022-04-12 10:47
Reporteranoleyn 
Assigned Tovmarkovtsev 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version0.98d 
Target VersionFixed in Version0.98g 
Summary0002264: Learning Stone not propely showing gained experience points
DescriptionVisiting the Learning Stone with a hero, who has 'Learning' as one of his secondary skills does not show properly given experience. It always shows 1000 exp, though it should more like in OH3, ie. 1050 exp with 5% skill, 1100 exp with 10% skill etc. It applies to artifacts, which increase that skill as well. Example:

        "bonuses":
        [
            {
                "type": "SECONDARY_SKILL_PREMY",
                "subtype" : "skill.learning",
                "val" : 15,
                "valueType": "ADDITIVE_VALUE"
            }
        ]

To be precise - the experience given in fact is correct, it is only improperly displayed. I do not know if its because of the Stone specifically or not - winning a battle shows gained experience properly.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0001989closed vmarkovtsev Stables not grade cavaliers in champions 
related to 0001916closed vmarkovtsev Water Wheel give 500 gold on week 2 (need 1000) 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-10-01 20:39anoleynNew Issue
2015-12-24 18:47SXXRelationship addedrelated to 0001989
2015-12-24 18:47SXXRelationship addedrelated to 0001916
2015-12-24 18:48SXXNote Added: 0006216
2015-12-24 18:49SXXStatusnew => acknowledged
2016-01-30 21:01vmarkovtsevAssigned To => vmarkovtsev
2016-01-30 21:01vmarkovtsevStatusacknowledged => assigned
2016-01-31 07:20vmarkovtsevNote Added: 0006391
2016-01-31 07:52WarmongerNote Added: 0006392
2016-01-31 19:40vmarkovtsevStatusassigned => resolved
2016-01-31 19:40vmarkovtsevFixed in Version => 0.98g
2016-01-31 19:40vmarkovtsevResolutionopen => fixed
2016-02-01 09:10WarmongerNote Edited: 0006392bug_revision_view_page.php?bugnote_id=6392#r3164
2022-04-12 10:47PovelitelStatusresolved => closed

Notes
(0006216)
SXX   
2015-12-24 18:48   
Just like two related issues this one is current limitation of rewardable object handler and some code outside of it need to be changed in order for this to work as in H3.
(0006391)
vmarkovtsev   
2016-01-31 07:20   
https://github.com/vcmi/vcmi/pull/185 [^]
(0006392)
Warmonger   
2016-01-31 07:52   
(edited on: 2016-02-01 09:10)
Another feature that got lost in refactoring. calculateXp() function was created just for that reason.