MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000216VCMIGUI - Town screenpublic2009-11-07 11:212013-06-02 14:38
ReporterZamolxis 
Assigned ToTow 
PriorityhighSeveritytrivialReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version0.74 
Target VersionFixed in Version0.89 
Summary0000216: VCMI-H3 discrepancy: VCMI uses hotkey 'T' to open Marketplace, while H3 used it for Towns on the map & Tight in hero screen
DescriptionH3 used 'T' for Towns on Adventure Map (select/focus first town in the list, then cycle through list) and for Tight formation in Hero Screen.

So 'T' needs to be re-allocated as per H3, and we need to find another hotkey for the Marketplace.

We cannot use 'M', because it is taken by Move. The only letters not used on H3 Adventure map as hotkeys were: B, F, G, J, R, X & Y. Of these, I'd say our best options are:

B = Buy
or
R = Resources

Whichever you choose, it's maybe good to implement it also in the CTRL+/SHIFT+ combinations, same as NWC did and to be consistent with how also the other hotkeys were implemented. I don't have a preference between B or R. The only thing is that R would conflict with Replay in the Adventure Options screen (and we could code it for Recruit in some other screens), so with the Marketplace coded to be called by hotkey from any screen, maybe it's best to go for B, which is not used in any H3 interface (and can't think of other use we can give it).
Steps To Reproduce
Additional InformationIf for any reason you prefer not using B or R, the next hotkeys which intuitively might pop to mind, are CTRL+M or CTRL+T. The problem is that in H3 they had the same function as M and T, however they were never documented in the H3 manual, so we are not so bound to implement them identically. And same goes for SHIFT+ combinations.

If we do implement CTRL+/SHIFT+ combinations exactly like H3 (alternatives to single hotkeys), then I guess we are left only with ALT+M or ALT+T for the Marketplace window (perhaps both?). These were not used in H3. However the risk here is that they may be less intuitive (though we will have a manual to take care of that I guess).
TagsNo-harm enhancement
Relationships
related to 0000602closed Ivan Pressing 'T' twice if player doesn't own any marketplace causes the game to freeze 
related to 0000907resolved Tow Hotkey suggestions for Thieves' Guild and Tavern 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-11-07 11:21ZamolxisNew Issue
2009-11-07 12:11ZamolxisSummary'T' was implemented to open Marketplace window, however in H3 'T' was used for cycling through the towns in the list => 'T' was implemented to open Marketplace window, however in H3 'T' was used for select & cycle through the towns in the list
2009-11-07 12:11ZamolxisDescription Updatedbug_revision_view_page.php?rev_id=339#r339
2009-11-07 12:11ZamolxisDescription Updatedbug_revision_view_page.php?rev_id=340#r340
2009-11-28 07:55WarmongerCategoryOther => GUI - Town screen
2010-11-22 11:16ZamolxisSummary'T' was implemented to open Marketplace window, however in H3 'T' was used for select & cycle through the towns in the list => VCMI-H3 discrepancy: VCMI uses hotkey 'T' to open Marketplace, while H3 used it for towns (select & cycle through list)
2010-11-22 11:16ZamolxisDescription Updatedbug_revision_view_page.php?rev_id=1204#r1204
2010-11-22 11:20ZamolxisDescription Updatedbug_revision_view_page.php?rev_id=1205#r1205
2010-11-22 11:20ZamolxisRelationship addedrelated to 0000602
2010-11-22 11:24ZamolxisDescription Updatedbug_revision_view_page.php?rev_id=1206#r1206
2010-11-22 11:53ZamolxisNote Added: 0001445
2010-11-22 11:55ZamolxisSeverityfeature => trivial
2010-11-22 12:51ZamolxisTag Attached: No-harm enhancement
2012-03-01 13:58ZamolxisDescription Updatedbug_revision_view_page.php?rev_id=1515#r1515
2012-03-11 13:21ZamolxisSummaryVCMI-H3 discrepancy: VCMI uses hotkey 'T' to open Marketplace, while H3 used it for towns (select & cycle through list) => VCMI-H3 discrepancy: VCMI uses hotkey 'T' to open Marketplace, while H3 used it for Towns on the map & Tight in hero screen
2012-03-11 13:21ZamolxisDescription Updatedbug_revision_view_page.php?rev_id=1536#r1536
2012-03-11 13:21ZamolxisAdditional Information Updatedbug_revision_view_page.php?rev_id=1538#r1538
2012-03-11 13:23ZamolxisNote Edited: 0001445bug_revision_view_page.php?bugnote_id=1445#r1540
2012-03-11 13:27ZamolxisNote Added: 0002304
2012-03-11 13:27ZamolxisPrioritynormal => high
2012-03-11 13:27ZamolxisNote Edited: 0002304bug_revision_view_page.php?bugnote_id=2304#r1542
2012-03-11 13:30ZamolxisDescription Updatedbug_revision_view_page.php?rev_id=1543#r1543
2012-03-11 15:22ZamolxisRelationship addedrelated to 0000907
2012-04-08 01:18TowNote Added: 0002334
2012-04-08 01:18TowStatusnew => resolved
2012-04-08 01:18TowFixed in Version => 0.89
2012-04-08 01:18TowResolutionopen => fixed
2012-04-08 01:18TowAssigned To => Tow
2013-06-02 14:38ZamolxisNote Added: 0003639
2013-06-02 14:38ZamolxisStatusresolved => closed

Notes
(0001445)
Zamolxis   
2010-11-22 11:53   
(edited on: 2012-03-11 13:23)
Thanks to phomm (0000602) we identified another discrepancy: in H3, T triggered Tight formation in Hero screen, while in VCMI opens Marketplace as well.

So as part of this fix, 'T' should also be re-allocated to Tight formation in Hero screen (updated in Report description as well).
(0002304)
Zamolxis   
2012-03-11 13:27   
Priority increased because - moving between H3 & VCMI for tests - I keep hitting T wanting to go to Towns, but I get something else in VCMI. I think this should change soon, before VCMI players get used to the wrong hotkey.
(0002334)
Tow   
2012-04-08 01:18   
Fixed in r2613.
Hotkey for marketplace will be CTRL+T. Implemented original T behavior for town switching. Tight formation hotkey was already implemented, the effect probably was suppresed by marketplace window.
(0003639)
Zamolxis   
2013-06-02 14:38   
Verified in 0.93 and confirmed as fixed.

Actually meanwhile hotkeys changed to following:
- On Adv.map "T" is for towns and "CTRL+T" for Trading Post
- both "T" and "CTRL+T" only select Tight formation in Hero screen

Maybe ideally CTRL+T should have opened trading post in Hero screen also, for rare situations like Gelu needing money to upgrade Sharpshooters, but that's such a rare need, that I don't think somebody will really miss it.