MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002089VCMIMechanics - Adventure Mappublic2015-02-15 08:572022-04-12 11:04
ReporterSXX 
Assigned ToSXX 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version0.97b 
Target VersionFixed in Version0.99 
Summary0002089: Multiplayer over network: heroes inside town displayed like they visiting it
DescriptionThis only affect games with 2+ clients connected to server. It's not affect hot seat!

Basically when you put hero inside castle it's shouldn't be visible on adventure map, but in case of network multiplayer it's doesn't work and heroes always displayed like if they were visiting town.

Multiplayer is pretty messy and need a lot of fixing of course, but this is one of not that obvious issue so I post it on bug tracker as @AVS said this may indicate gamestate desync which may not end up well.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-02-15 08:57SXXNew Issue
2016-08-23 05:10SXXRelationship addedchild of 0002459
2016-08-23 05:11SXXNote Added: 0006582
2016-08-23 05:12SXXNote Edited: 0006582bug_revision_view_page.php?bugnote_id=6582#r3216
2016-09-08 15:44SXXNote Added: 0006633
2016-09-11 10:11SXXRelationship deletedchild of 0002459
2016-09-11 10:11SXXNote Added: 0006639
2016-09-11 10:13SXXNote Edited: 0006639bug_revision_view_page.php?bugnote_id=6639#r3224
2016-09-11 10:57SXXNote Added: 0006640
2016-09-11 10:57SXXStatusnew => resolved
2016-09-11 10:57SXXFixed in Version => 0.99
2016-09-11 10:57SXXResolutionopen => fixed
2016-09-11 10:57SXXAssigned To => SXX
2016-09-11 10:58SXXNote Added: 0006641
2022-04-12 11:04PovelitelStatusresolved => closed

Notes
(0006582)
SXX   
2016-08-23 05:11   
(edited on: 2016-08-23 05:12)
Didn't tested it, but considering nobody really touch multiplayer almost sure there something wrong with netpacks or server code for town visits.

So this is another source of desyncs that need to be checked for 0002459.
(0006633)
SXX   
2016-09-08 15:44   
So far can't find why it's happening. Probably issue was fixed already.
(0006639)
SXX   
2016-09-11 10:11   
(edited on: 2016-09-11 10:13)
Problem still there, but I pretty sure it's entirely client-side. :-)

CPlayerInterface::heroInGarrisonChange
(0006640)
SXX   
2016-09-11 10:57   
Fixed:

https://github.com/vcmi/vcmi/commit/9ab7650746f6f590e7d825e1c27846b41ddfb6ab [^]
(0006641)
SXX   
2016-09-11 10:58   
PS: Please keep in mind multiplayer currently still broken in develop.