MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002083VCMIMechanics - Objectspublic2015-02-14 19:222022-04-12 09:17
ReporterKantor 
Assigned ToSXX 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version0.97b 
Target VersionFixed in Version0.98f 
Summary0002083: Stables bonus is always reset at the beginning of 2nd day of new week
DescriptionStables (and probably other alike objects, not sure here) bonus is always reset at the beginning of 2nd day of new week, but should disappear at first day of new week.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0002356assigned SXX New turn handling need refactoring 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-02-14 19:22KantorNew Issue
2015-02-14 19:27KantorSummaryStables bonus is always reset at the beginning of 2nd day => Stables bonus is always reset at the beginning of 2nd day of new week
2015-02-15 04:06SXXRelationship addedrelated to 0001989
2015-12-24 22:56SXXNote Added: 0006221
2015-12-24 22:56SXXStatusnew => resolved
2015-12-24 22:56SXXFixed in Version => 0.98f
2015-12-24 22:56SXXResolutionopen => fixed
2015-12-24 22:56SXXAssigned To => SXX
2015-12-24 22:56SXXRelationship deletedrelated to 0001989
2015-12-24 23:16SXXNote Added: 0006223
2015-12-24 23:16SXXStatusresolved => assigned
2015-12-24 23:20SXXNote Edited: 0006223bug_revision_view_page.php?bugnote_id=6223#r3079
2015-12-25 08:17SXXRelationship addedrelated to 0002356
2015-12-25 08:19SXXNote Added: 0006224
2015-12-25 08:19SXXStatusassigned => resolved
2022-04-12 09:17PovelitelStatusresolved => closed

Notes
(0006221)
SXX   
2015-12-24 22:56   
Fixed:
https://github.com/vcmi/vcmi/commit/66e6f15e671e1d5b9ed6b893632230fab619710c [^]
(0006223)
SXX   
2015-12-24 23:16   
(edited on: 2015-12-24 23:20)
Oops, right reason but wrong fix. Probably I must get some sleep.
(0006224)
SXX   
2015-12-25 08:19   
Ok here we go:
https://github.com/vcmi/vcmi/commit/6985e96f0d28118315d89f6fddf826e5d210c2ba [^]

This must fix all possible issues with hero because TurnInfo is designed to work out such situations when we want to check bonuses for certain day. Though if we eventually have player-wide bonuses from map objects we really need to rework all this code.