MantisBT - VCMI
View Issue Details
0001989VCMIMechanics - Objectspublic2014-12-10 17:502016-04-07 13:44
Povelitel 
vmarkovtsev 
normalminoralways
closedfixed 
0.97 
0.98g 
0001989: Stables not grade cavaliers in champions
When visiting the stables can be done free upgrade. This is not happening.
No tags attached.
related to 0001912closed SXX Stables not give a bonus movement points? 
related to 0001916closed vmarkovtsev Water Wheel give 500 gold on week 2 (need 1000) 
related to 0002264resolved vmarkovtsev Learning Stone not propely showing gained experience points 
Issue History
2014-12-10 17:50PovelitelNew Issue
2014-12-10 17:50PovelitelStatusnew => assigned
2014-12-10 17:50PovelitelAssigned To => Warmonger
2014-12-10 21:43WarmongerRelationship addedrelated to 0001912
2014-12-10 22:16PovelitelNote Added: 0005210
2014-12-20 14:11SXXNote Added: 0005225
2015-01-08 08:14SXXNote Added: 0005368
2015-01-08 08:15SXXNote Edited: 0005368bug_revision_view_page.php?bugnote_id=5368#r2785
2015-02-15 04:06SXXRelationship addedrelated to 0002083
2015-10-17 02:29SXXRelationship addedrelated to 0001916
2015-12-24 18:47SXXRelationship addedrelated to 0002264
2015-12-24 18:49SXXAssigned ToWarmonger =>
2015-12-24 18:49SXXStatusassigned => acknowledged
2015-12-24 22:56SXXRelationship deletedrelated to 0002083
2016-01-30 16:29vmarkovtsevAssigned To => vmarkovtsev
2016-01-30 16:29vmarkovtsevStatusacknowledged => assigned
2016-01-30 17:42WarmongerNote Added: 0006387
2016-01-30 17:42WarmongerNote Edited: 0006387bug_revision_view_page.php?bugnote_id=6387#r3160
2016-01-30 20:59vmarkovtsevNote Added: 0006389
2016-01-30 21:00vmarkovtsevNote Added: 0006390
2016-02-02 01:02SXXStatusassigned => resolved
2016-02-02 01:02SXXFixed in Version => 0.98g
2016-02-02 01:02SXXResolutionopen => fixed
2016-04-07 13:44PovelitelStatusresolved => closed

Notes
(0005210)
Povelitel   
2014-12-10 22:16   
Not sure, but probably applies here 1972 too
(0005225)
SXX   
2014-12-20 14:11   
This one isn't implemented yet. There is some code to do the upgrade, but it's comented out as TODO.
(0005368)
SXX   
2015-01-08 08:14   
(edited on: 2015-01-08 08:15)
Interesting note on H3 behaviour for this upgrade.

In H3 hero that have Champions in his army get upgrade even if he already visited stables in Castle Town this week. Though caption on hover still show stables as "visited" for such hero before upgrade.

(0006387)
Warmonger   
2016-01-30 17:42   
>> There is some code to do the upgrade, but it's comented out as TODO.

I wrote that part and it worked at least, didn't see any complains or bug reports. Probably got commented out on object refactoring.

(0006389)
vmarkovtsev   
2016-01-30 20:59   
https://github.com/vcmi/vcmi/pull/183 [^]
I preserved every aspect from OH3 - even UI behavior with already visited stables, as SXX described.
(0006390)
vmarkovtsev   
2016-01-30 21:00   
@Warmonger: some refactoring rendered your code useless, so it was commented out. I had to kind of hack to recover.