MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001912VCMIMechanics - Objectspublic2014-10-07 16:122015-04-11 18:07
ReporterPovelitel 
Assigned ToSXX 
PrioritynormalSeverityminorReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version0.96b 
Target VersionFixed in Version0.97b 
Summary0001912: Stables not give a bonus movement points?
DescriptionDrew attention to that when you visit the stables are not added to points of movement. (400)
Steps To Reproduce
Additional InformationAt least in this save game
TagsNo tags attached.
Relationships
has duplicate 0001942closed SXX Stables doesn't work, no text message 
has duplicate 0001938closed SXX Faerie Ring doesn't work and shows no text 
has duplicate 0001943closed SXX Bouy doesn't work - no effect, no text message 
has duplicate 0001940closed SXX Idol of Fortune doesn't work, no text message 
has duplicate 0001939closed SXX Swan Pond doesn't work, no text message 
has duplicate 0001972closed SXX after loading saves stables stop working 
related to 0001989closed vmarkovtsev Stables not grade cavaliers in champions 
Attached Filesrar Saves.rar (1,256,330) 2014-10-07 16:12
https://bugs.vcmi.eu/file_download.php?file_id=1928&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-10-07 16:12PovelitelNew Issue
2014-10-07 16:12PovelitelStatusnew => assigned
2014-10-07 16:12PovelitelAssigned To => Warmonger
2014-10-07 16:12PovelitelFile Added: Saves.rar
2014-11-10 12:31WarmongerRelationship addedhas duplicate 0001942
2014-12-10 21:43WarmongerRelationship addedrelated to 0001989
2014-12-20 14:37SXXNote Added: 0005226
2014-12-20 14:37SXXRelationship addedhas duplicate 0001938
2014-12-20 14:37SXXRelationship addedrelated to 0001939
2014-12-20 14:38SXXRelationship addedrelated to 0001940
2014-12-20 14:38SXXRelationship addedhas duplicate 0001943
2014-12-20 14:38SXXRelationship deletedrelated to 0001940
2014-12-20 14:38SXXRelationship deletedrelated to 0001939
2014-12-20 14:38SXXRelationship addedhas duplicate 0001940
2014-12-20 14:39SXXRelationship addedrelated to 0001939
2014-12-20 14:39SXXRelationship deletedrelated to 0001939
2014-12-20 14:39SXXRelationship addedhas duplicate 0001939
2014-12-20 14:39SXXRelationship addedhas duplicate 0001972
2014-12-20 14:40SXXNote Edited: 0005226bug_revision_view_page.php?bugnote_id=5226#r2752
2014-12-20 14:42SXXNote Edited: 0005226bug_revision_view_page.php?bugnote_id=5226#r2753
2014-12-20 15:14SXXNote Added: 0005232
2014-12-20 15:20WarmongerNote Added: 0005233
2014-12-20 15:20WarmongerNote Edited: 0005233bug_revision_view_page.php?bugnote_id=5233#r2755
2014-12-20 15:48SXXNote Added: 0005234
2014-12-21 11:27SXXAssigned ToWarmonger => SXX
2014-12-22 09:44SXXNote Added: 0005247
2014-12-25 14:06SXXNote Added: 0005280
2014-12-25 14:06SXXStatusassigned => resolved
2014-12-25 14:06SXXFixed in Version => 0.97b
2014-12-25 14:06SXXResolutionopen => fixed
2014-12-25 19:11WarmongerNote Added: 0005283
2014-12-25 19:36SXXNote Added: 0005286
2015-04-11 18:07PovelitelStatusresolved => closed

Notes
(0005226)
SXX   
2014-12-20 14:37   
(edited on: 2014-12-20 14:42)
This problem described a bit better in 0001972: problem only occur after you load save game.
All objects using CGBonusingObject handler affected:

  - Obj::BUOY
  - Obj::SWAN_POND
  - Obj::FAERIE_RING
  - Obj::FOUNTAIN_OF_FORTUNE
  - Obj::IDOL_OF_FORTUNE
  - Obj::MERMAID
  - Obj::RALLY_FLAG
  - Obj::OASIS
  - Obj::TEMPLE
  - Obj::WATERING_HOLE
  - Obj::FOUNTAIN_OF_YOUTH
  - Obj::STABLES

Investigate this one as moment. So far I notice that "CGBonusingObject::initObj" not called on loading of save.
This possible because all objects state have to be loaded from save already or this is reason of problem.
(0005232)
SXX   
2014-12-20 15:14   
So according to logs when "CRewardableObject::onHeroVisit" check what rewards are available "CRewardableObject::getAvailableRewards" return there is zero rewards available for this object.
(0005233)
Warmonger   
2014-12-20 15:20   
Probably some property is not serialized (once again).
(0005234)
SXX   
2014-12-20 15:48   
Yeah.

@AVS already gived me a hint that problem occur because it's serializes CGObjectInstance and not CRewardableObject.
(0005247)
SXX   
2014-12-22 09:44   
https://github.com/vcmi/vcmi/pull/67 [^]
(0005280)
SXX   
2014-12-25 14:06   
Should be now fixed in git:
https://github.com/vcmi/vcmi/commit/5d59bbc0d4fd80cc14deba7de0c0f26016dc4e1c [^]
(0005283)
Warmonger   
2014-12-25 19:11   
It's better to mark all related reports as "resolved in 0.next" so people can see it in a changelog. You can close them later.
(0005286)
SXX   
2014-12-25 19:36   
Done. Hope it's what you mean :-)