|
Notes |
|
|
|
|
|
|
(0005037)
|
|
Warmonger
|
2014-10-29 17:51
(edited on: 2014-10-29 18:07) |
|
Game crashes when rendering first free slot, not sure why. Probably issue with block() function.
|
|
|
|
(0005117)
|
|
Noui
|
2014-11-17 11:12
(edited on: 2014-11-17 11:19) |
|
I can confirm that it doesn't crash as early when the visiting hero doesn't have any free army slots. However, the game does crash when I try to upgrade creatures.
Edit: The game doesn't crash if you upgrade your creatures using the "upgrade all" button, but it does crash if you try to upgrade one specific creature.
|
|
|
|
(0005349)
|
|
SXX
|
|
2015-01-06 16:25
|
|
If no one else doing it at moment I'll start to investigate/fix this one.
So far I'm find out that "upgrade all" button work properly. |
|
|
|
(0005350)
|
|
SXX
|
|
2015-01-06 17:10
|
|
So problems found that I see after some testing:
1 - Most likely crash with empty slots occur because attempt to "block" non-exist button.
2 - If you attempt to upgrade one unit there is crash (assert) in makeDeal as it's get garbage instead of slot id. Likely occur due to bad code at /client/windows/GUIClasses.cpp:1396
3 - IDs for single unit upgrade also may become messed up a bit. E.g unit in previous slot upgraded instead of choosen one. |
|
|
|
(0005351)
|
|
SXX
|
|
2015-01-06 17:18
|
|
2 - So it's just invalid capture for lambda here: "&" (grab reference) instead of needed "=":
[&]{ makeDeal(SlotID(i)) };
It's grab reference for i in loop which is obviously become garbade by the time it's called. :-) |
|
|
|
|
|
Did that work? I think that's first thing I tried, but with no sucess at that time. |
|
|
|
(0005354)
|
|
SXX
|
2015-01-07 10:14
(edited on: 2015-01-07 10:31) |
|
Yeah of course, but there also needed fix crash that occur on button state change. E.g by default game is trying to set state to -1 for empty slots as result there no image for button found and button remain disabled. And code attempt to "block" it cause client crash.
|
|
|
|
(0005355)
|
|
SXX
|
|
2015-01-07 10:22
|
|
|
|
|
(0005360)
|
|
SXX
|
|
2015-01-07 15:11
|
|
|
Revenge 113.h3m (245,211) 2014-09-26 10:24
VCMI_Client_log.txt (2,515,261) 2014-09-26 10:25