MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001599VCMIMechanics - Objectspublic2013-11-29 19:302014-06-02 08:36
Reporteranoleyn 
Assigned ToWarmonger 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version0.94 
Target VersionFixed in Version0.94f 
Summary0001599: After loading heroes loose their abilities
DescriptionPlaying standard heroes like Gelu or Dracon (as well as the ones added by mods with similar abilities) is bugged. After starting a game, saving and then loading the save, the heroes loose their special abilities to upgrade units.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
parent of 0001558closed Warmonger Heroy Gelu, doesn't convert archers in sharpshooters. 
has duplicate 0001654closed Warmonger Gelu\Dracon Speciality 
related to 0001564closed Warmonger Galtran not have +1 speed scelets 
related to 0001573closed Warmonger Sir Mullich not have +2 speed 
Attached Files? GELU.bmp (1,529,494) 2013-11-29 19:30
https://bugs.vcmi.eu/file_download.php?file_id=1627&type=bug
Issue History
Date ModifiedUsernameFieldChange
2013-11-29 19:30anoleynNew Issue
2013-11-29 19:30anoleynFile Added: GELU.bmp
2013-11-29 19:32anoleynNote Added: 0004143
2013-11-29 20:07WarmongerRelationship addedparent of 0001558
2013-11-29 20:07WarmongerAssigned To => Warmonger
2013-11-29 20:07WarmongerStatusnew => assigned
2013-11-29 20:08WarmongerRelationship addedrelated to 0001600
2013-11-29 20:08WarmongerRelationship addedrelated to 0001564
2013-11-29 20:09WarmongerRelationship addedrelated to 0001573
2013-12-01 15:44WarmongerNote Added: 0004150
2013-12-01 15:44WarmongerStatusassigned => confirmed
2014-01-14 16:20IvanRelationship addedhas duplicate 0001654
2014-02-17 05:51WarmongerCategoryGUI - Hero screen / Exchange window => Mechanics - Objects
2014-02-17 17:29WarmongerNote Added: 0004486
2014-02-17 17:29WarmongerStatusconfirmed => resolved
2014-02-17 17:29WarmongerFixed in Version => 0.94f
2014-02-17 17:29WarmongerResolutionopen => fixed
2014-05-16 17:24WarmongerRelationship deletedrelated to 0001600
2014-06-01 21:47KantorNote Added: 0004713
2014-06-02 08:36KantorStatusresolved => closed

Notes
(0004143)
anoleyn   
2013-11-29 19:32   
Sorry for the spelling mistake (loose) :)
(0004150)
Warmonger   
2013-12-01 15:44   
Looks like another serialization issue. There are two solutions:

- Serialize CGHeroInstance::HeroSpecial as pointer vector type - confusing, as there is no logical place where one big vector should be stored
- Allow to attach hero speciality to hero itself without the use of pointer. Or emulate propagation of bonuses between these two in any other way.
(0004486)
Warmonger   
2014-02-17 17:29   
Fixed in r3757.
(0004713)
Kantor   
2014-06-01 21:47   
This one may be closed.