MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001583VCMIGUI - Adventure Mappublic2013-11-10 17:492022-04-12 09:17
Reporterbeegee 
Assigned ToWarmonger 
PrioritynormalSeveritytweakReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version0.94 
Target VersionFixed in Version0.98e 
Summary0001583: Player warning 'you only have x days left to capture a town' doesn't popup the first time + further tweaks for player warnings
Description1) The player warning 'you only have x days left to capture a town' doesn't popup for the first day without having any town.

It's a minor issue and not so easy to fix, but I want to hold it somewhere. (see more details below)

2) Further tweaks:
- Instead of the player color, the name of the player should be displayed in those player warning messages (only affects hot-seat games)
Steps To Reproduce1. Conquer town with player A
2. Next turn
3. No message for player B
Additional InformationThe problem has to do with the way player warnings are sent to clients. Those messages are generated on the server for every round/day. The town is lost during the first day, so the message wasn't created and so the client can't display it.

EDIT: We could also generate player warnings on the client side along with "Player's turn." message
TagsNo tags attached.
Relationships
related to 0002072closed Warmonger After loading save of last 7 day without town you lose 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-11-10 17:49beegeeNew Issue
2013-11-10 17:58beegeeSummaryPlayer warning 'you only have x days left to capture a town' doesn't popup the first time => Player warning 'you only have x days left to capture a town' doesn't popup the first time + further tweaks for player warnings
2013-11-10 17:58beegeeDescription Updatedbug_revision_view_page.php?rev_id=2433#r2433
2013-11-11 11:55beegeeAdditional Information Updatedbug_revision_view_page.php?rev_id=2435#r2435
2013-11-30 09:53beegeeDescription Updatedbug_revision_view_page.php?rev_id=2444#r2444
2013-11-30 09:53beegeeDescription Updatedbug_revision_view_page.php?rev_id=2445#r2445
2013-11-30 09:54beegeeNote Added: 0004145
2013-11-30 09:58beegeeDescription Updatedbug_revision_view_page.php?rev_id=2446#r2446
2013-12-08 18:01beegeeDescription Updatedbug_revision_view_page.php?rev_id=2460#r2460
2015-10-24 15:58WarmongerRelationship addedrelated to 0002072
2015-10-24 16:22WarmongerNote Added: 0005978
2015-10-24 16:22WarmongerStatusnew => resolved
2015-10-24 16:22WarmongerFixed in Version => 0.98e
2015-10-24 16:22WarmongerResolutionopen => fixed
2015-10-24 16:22WarmongerAssigned To => Warmonger
2022-04-12 09:17PovelitelStatusresolved => closed

Notes
(0004145)
beegee   
2013-11-30 09:54   
Point 1) has been fixed in revision 3631. Player warnings are generated on the client side.
(0005978)
Warmonger   
2015-10-24 16:22   
Possibly fixed in https://github.com/vcmi/vcmi/commit/61692ba168bafa5f08df9bbd7526bf21339b0dcb [^]