MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001392VCMIMechanics - Objectspublic2013-08-01 18:182022-04-12 09:17
ReporterWarmonger 
Assigned ToSXX 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version0.93 
Target Version0.94Fixed in Version0.97b 
Summary0001392: It's not possible to sell spell scrolls in Artifact Merchant
DescriptionIt should be impossible to sacrifice them on Altar, but selling scrolls should work in towns.

From Strategija:
Selling scrolls can be extremely profitable: e.g. with 3 Marketplaces they go for 750 gold regardless of level. On randoms, where it is often easy to accumulate plenty of them, they alone can easily pay off Artifact Merchant investment.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0001366resolved Dydzio Black market: it is possible to sell more resources than needed 
related to 0000558assigned Chocimier Altar of Sacrifice: Mechanics + GUI issues 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-08-01 18:18WarmongerNew Issue
2013-08-01 18:18WarmongerStatusnew => assigned
2013-08-01 18:18WarmongerAssigned To => Warmonger
2013-08-01 18:18WarmongerAssigned ToWarmonger =>
2013-08-01 18:18WarmongerStatusassigned => new
2013-08-01 18:18WarmongerRelationship addedrelated to 0001366
2013-08-01 18:20WarmongerSummaryIt's not possible to sell spell scrolls in Artifatc Merchant => It's not possible to sell spell scrolls in Artifact Merchant
2013-08-01 18:20WarmongerDescription Updatedbug_revision_view_page.php?rev_id=2359#r2359
2014-12-24 18:06SXXNote Added: 0005266
2014-12-24 18:06SXXAssigned To => SXX
2014-12-24 18:06SXXStatusnew => assigned
2014-12-24 22:35SXXRelationship addedrelated to 0000558
2015-01-08 07:18SXXNote Added: 0005366
2015-01-08 07:18SXXStatusassigned => resolved
2015-01-08 07:18SXXFixed in Version => 0.97b
2015-01-08 07:18SXXResolutionopen => fixed
2015-01-08 07:29WarmongerNote Added: 0005367
2022-04-12 09:17PovelitelStatusresolved => closed

Notes
(0005266)
SXX   
2014-12-24 18:06   
So I fixed this one in my private branch:
https://github.com/ArseniyShestakov/vcmi/commits/artifactsImprovements [^]
Once I finish other small artifact-related fixes I'll will sent pull request.

What I have question about is spell scrolls on Altar of Sacrifice in both VCMI and H3 give zero expirience anyway. Is there real need to block player's ability to put them here for whatever reason?
(0005366)
SXX   
2015-01-08 07:18   
Should mark it as fixed long time ago:
https://github.com/vcmi/vcmi/commit/4cb98e7e8d1d8112c9e54a370a7314ea45bf95e9 [^]

@Warmonger still if you think there is need to block player's ability to sell something that give zero gold or exp in return let me know.
(0005367)
Warmonger   
2015-01-08 07:29   
I think that ability to sell / sacrifice spell scrolls in the field could make some random maps unbalanced. Artifact Merchant in town costs a lot to make up for it.

What I would like to do is prevent players from selling quest items. These may be related - if you don't want some artifact to be sold by accident, set its value to 0. But there are more possibilities (prevent selling 'special' artifact, for example).
Either way, this feature won't be useful until map editor is ready. For now please leave the backdoor to prevent some artifacts from trading.