MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001390VCMIGUI - Battlespublic2013-08-01 07:032016-11-11 08:26
ReporterWarmonger 
Assigned ToAVS 
PrioritynormalSeveritycrashReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version0.93 
Target Version0.94Fixed in Version0.98d 
Summary0001390: Crash in creaure window after multiple Blind / Stone gaze casts
DescriptionWhen petrify / blind is cast by creature for first time, everything works fine. Bonuses are stored in "bonuses" field and dissapear after stack is attacked. However, after next casts, debugger shows that this line fails:

int duration = battleStack->getBonusLocalFirst(Selector::source(Bonus::SPELL_EFFECT,effect))->turnsRemain;

Indeed, spell bonuses are now stored in "exportedBonuses" field rather that just "bonuses" and are never accessed.
Steps To ReproduceUse attached map, attack Basilisks with Sir Mullich.
Additional Information
TagsNo tags attached.
Relationships
related to 0001359closed AVS Incorrect turn order in battle, related to Basilisks petrification 
related to 0000528closed AVS Blind spell implemented incorrectly 
parent of 0001398closed Warmonger Bag poison vivern 
has duplicate 0001466closed AVS incorrect work spell blind 
has duplicate 0001809closed AVS ability skorpikor (and crash for RMB) 
related to 0001801resolved  Crash during battle 
related to 0001806closed AVS ability scorpicor not lost, after hitting unit. 
related to 0001915closed AVS Frenzy - crash 
child of 0002185closed AVS Bonus system: incorrect usage of CBonusSystemNode::bonuses 
Attached Files? Testy4 Power Rating.h3m (3,375) 2013-08-01 07:06
https://bugs.vcmi.eu/file_download.php?file_id=1408&type=bug
Issue History
Date ModifiedUsernameFieldChange
2013-08-01 07:03WarmongerNew Issue
2013-08-01 07:03WarmongerRelationship addedrelated to 0001359
2013-08-01 07:04WarmongerRelationship addedrelated to 0000528
2013-08-01 07:05WarmongerAssigned To => Tow
2013-08-01 07:05WarmongerStatusnew => assigned
2013-08-01 07:06WarmongerFile Added: Testy4 Power Rating.h3m
2013-08-01 07:06WarmongerSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=2351#r2351
2013-08-04 05:46WarmongerRelationship addedparent of 0001398
2013-09-13 16:26WarmongerRelationship addedhas duplicate 0001466
2013-11-10 16:48beegeeNote Added: 0004122
2014-06-13 20:41WarmongerRelationship addedrelated to 0001801
2014-06-28 19:40WarmongerRelationship addedparent of 0001809
2014-12-20 10:53WarmongerRelationship addedrelated to 0001806
2014-12-20 10:54WarmongerRelationship replacedhas duplicate 0001809
2015-04-03 09:17WarmongerRelationship addedrelated to 0001915
2015-04-13 04:04AVSAssigned ToTow => AVS
2015-04-13 04:59AVSRelationship addedchild of 0002185
2015-09-14 13:20AVSNote Added: 0005847
2015-09-14 13:20AVSStatusassigned => resolved
2015-09-14 13:20AVSFixed in Version => 0.98d
2015-09-14 13:20AVSResolutionopen => fixed
2016-11-11 08:26SXXStatusresolved => closed

Notes
(0004122)
beegee   
2013-11-10 16:48   
The bug comes from the bonus system caching. If it's deactivated the blind spell disappears correctly and you can open the creature window. Perhaps the problems of the related mantis points depend as well on caching.

Without caching the battle runs a few times slower, especially if they're stacks which can fly.

The whole bonus system is quite complex. We can disable caching for now till the caching bugs are fixed. I think it's better to re-design some parts of the caching/bonus system than to fix bugs in the way it's cached currently. Perhaps I have more time in december to look into this problem extensively.
(0005847)
AVS   
2015-09-14 13:20   
should be already fixed