MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000132VCMIGUI - PreGamepublic2009-10-11 13:542010-05-29 11:21
ReporterZamolxis 
Assigned ToTow 
PriorityhighSeveritytweakReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version0.74 
Target VersionFixed in Version0.75 
Summary0000132: Client window is not centered when we begin a game in higher resolutions (ends up partly out of the screen area)
Description0.73c#2 - As of 0.74 the client window gets centered when we start the application, however that causes the AdvMap to be often more out of the screen at game start when we play on higher resolutions (1280x and above).

Before the client was starting randomly placed, but usually close to the upper left corner of the screen. As a result, high resolution interfaces had a higher chance to be in the visible area at map start. For high resolution desktops however, centering the client meant moving it lower and to the right. But as the AdvMap starts through expansion to the right and to the bottom, that means the right and lower areas are not visible anymore when we start a game in 1280x/1440x/1600x resolutions (unless someone has 30" monitors :p).

So we need the client window to re-center depending on chosen resolution at map start.
Steps To Reproduce
Additional InformationForum report: http://forum.vcmi.eu/viewtopic.php?p=3629#3629 [^]
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-10-11 13:54ZamolxisNew Issue
2009-10-11 14:00ZamolxisNote Added: 0000090
2009-10-11 14:58WarmongerNote Added: 0000092
2009-10-11 14:58WarmongerPrioritynormal => high
2009-10-11 15:21ZamolxisNote Added: 0000093
2009-11-28 11:36ZamolxisSticky IssueNo => Yes
2009-11-28 11:42ZamolxisNote Added: 0000280
2009-11-28 11:46ZamolxisNote Edited: 0000280bug_revision_view_page.php?bugnote_id=280#r389
2009-11-28 17:26TowNote Added: 0000305
2009-11-28 17:26TowStatusassigned => resolved
2009-11-28 17:26TowFixed in Version => SVN
2009-11-28 17:26TowResolutionopen => fixed
2009-11-28 17:34ZamolxisNote Added: 0000306
2009-11-28 17:34ZamolxisSticky IssueYes => No
2009-12-23 00:12ZamolxisNote Added: 0000471
2009-12-23 00:12ZamolxisNote Edited: 0000471bug_revision_view_page.php?bugnote_id=471#r486
2010-05-29 11:21ZamolxisStatusresolved => closed

Notes
(0000090)
Zamolxis   
2009-10-11 14:00   
The client recentering was implementing following a feature request from Warmonger here: http://forum.vcmi.eu/viewtopic.php?p=3431#3431. [^] However he mentions 1280 x 960 in the request, which means also the AdvMap.

I was even tempted to give "high" priority when I created my report, because current behavior forced me to switch to a lower default resolution, even though I really prefer testing on high resolutions. So it would be great if this could be fixed by the next release. Thanks in advance. ;)
(0000092)
Warmonger   
2009-10-11 14:58   
Increased priority. This one is really annoying as I have to move window manually every game during tests if in high resolution.
(0000093)
Zamolxis   
2009-10-11 15:21   
Thanks. I didn't know if it's not maybe just me getting annoyed by that. :)
(0000280)
Zamolxis   
2009-11-28 11:42   
(edited on: 2009-11-28 11:46)
Tow, I know you are very short in time these days (it almost makes me feel bad to ask this), but if it's possible to fix this, it would be great. I really prefer high resolutions, but I can't use them if every time I start the game, half the interface is out of the screen.

And February 1st sound like such a long wait otherwise... :p

I'll have more time to test around Christmas & New Year than I had the whole year all together, but it would be so much nicer if I could do it on high resolutions.
(0000305)
Tow   
2009-11-28 17:26   
I committed a quick and dirty that should fix centering on Windows.
Hopefully fixed in r1372 then.
(0000306)
Zamolxis   
2009-11-28 17:34   
Thanks. :)
(0000471)
Zamolxis   
2009-12-23 00:12   
@Tow: Seems fixed in 0.75.

However you mention a "quick and dirty fix for Windows". Shall I leave this in Resolved, but still Open, until a better coding is done for this (if necessary)?