MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001291VCMISound, music, videospublic2013-06-02 10:412022-04-11 17:49
Reporteramvmichael 
Assigned ToIvan 
PrioritynormalSeveritycrashReproducibilityalways
StatusclosedResolutionfixed 
Platformx64OSWinOS Version7
Product Version0.93 
Target VersionFixed in Version0.94 
Summary0001291: Crash when entering town
DescriptionMaybe sudden switch of music causes this? Eiter this ,or save game got corrupted.
Steps To ReproduceLaunch vcmi, load saved game , pick resources from dancing guy, pick def, 2 click on city (not city icon, didn't check if it crashes like that) to take a look.


Additional InformationH3 gold clean install, vcmi on default settings.
TagsNo tags attached.
Relationships
has duplicate 0001325closed Tow Crash when trying to open town screen after loading the savegame 
has duplicate 0001324closed Tow cleack in icon castle 
related to 0001320closed Tow Crash when end turn or enter town and click hero or creatures 
Attached Files? Arrogance Allied.h3m (12,226) 2013-06-02 10:41
https://bugs.vcmi.eu/file_download.php?file_id=1301&type=bug
? VCMI_client.exe_crashinfo.dmp (1,215,365) 2013-06-02 10:54
https://bugs.vcmi.eu/file_download.php?file_id=1302&type=bug
txt VCMI_Client_log.txt (20,015) 2013-06-02 10:54
https://bugs.vcmi.eu/file_download.php?file_id=1303&type=bug
txt VCMI_Client_log1.txt (4,536,837) 2013-06-02 10:55
https://bugs.vcmi.eu/file_download.php?file_id=1304&type=bug
? VCMI_client.exe_crashinfo1.dmp (1,204,177) 2013-06-02 10:55
https://bugs.vcmi.eu/file_download.php?file_id=1305&type=bug
? Autosave_4.vcgm1 (804,789) 2013-06-02 10:56
https://bugs.vcmi.eu/file_download.php?file_id=1306&type=bug
? Autosave_4.vsgm1 (801,757) 2013-06-02 10:56
https://bugs.vcmi.eu/file_download.php?file_id=1307&type=bug
7z 2013-06-10_CrashEnteringTown.7z (325,035) 2013-06-13 09:50
https://bugs.vcmi.eu/file_download.php?file_id=1373&type=bug
Issue History
Date ModifiedUsernameFieldChange
2013-06-02 10:41amvmichaelNew Issue
2013-06-02 10:41amvmichaelFile Added: Arrogance Allied.h3m
2013-06-02 10:54amvmichaelFile Added: VCMI_client.exe_crashinfo.dmp
2013-06-02 10:54amvmichaelFile Added: VCMI_Client_log.txt
2013-06-02 10:55amvmichaelFile Added: VCMI_Client_log1.txt
2013-06-02 10:55amvmichaelFile Added: VCMI_client.exe_crashinfo1.dmp
2013-06-02 10:56amvmichaelFile Added: Autosave_4.vcgm1
2013-06-02 10:56amvmichaelFile Added: Autosave_4.vsgm1
2013-06-02 11:30amvmichaelNote Added: 0003630
2013-06-02 12:29amvmichaelNote Edited: 0003630bug_revision_view_page.php?bugnote_id=3630#r2245
2013-06-02 14:24TowNote Added: 0003635
2013-06-02 18:35IvanNote Added: 0003643
2013-06-02 18:35IvanAssigned To => Ivan
2013-06-02 18:35IvanStatusnew => assigned
2013-06-02 18:59IvanNote Added: 0003644
2013-06-02 18:59IvanStatusassigned => resolved
2013-06-02 18:59IvanFixed in Version => 0.94
2013-06-02 18:59IvanResolutionopen => fixed
2013-06-08 07:14ZamolxisNote Added: 0003673
2013-06-08 07:14ZamolxisStatusresolved => feedback
2013-06-08 07:14ZamolxisResolutionfixed => reopened
2013-06-08 07:14ZamolxisFile Added: 2013-06-08_CrashChangingTowns.7z
2013-06-08 07:35ZamolxisFile Deleted: 2013-06-08_CrashChangingTowns.7z
2013-06-08 07:35ZamolxisStatusfeedback => resolved
2013-06-08 07:35ZamolxisResolutionreopened => fixed
2013-06-08 07:37ZamolxisNote Edited: 0003673bug_revision_view_page.php?rev_id=2291
2013-06-08 07:40ZamolxisNote Edited: 0003673bug_revision_view_page.php?rev_id=2292
2013-06-11 17:12ZamolxisNote Added: 0003704
2013-06-11 17:12ZamolxisStatusresolved => feedback
2013-06-11 17:12ZamolxisResolutionfixed => reopened
2013-06-11 17:12ZamolxisNote Deleted: 0003673
2013-06-13 09:50ZamolxisFile Added: 2013-06-10_CrashEnteringTown.7z
2013-06-13 09:51ZamolxisNote Edited: 0003704bug_revision_view_page.php?bugnote_id=3704#r2320
2013-07-08 16:25IvanNote Added: 0003741
2013-07-08 16:25IvanStatusfeedback => resolved
2013-07-08 16:25IvanResolutionreopened => fixed
2013-07-08 16:25IvanRelationship addedhas duplicate 0001325
2013-07-08 16:26IvanRelationship addedhas duplicate 0001324
2013-08-15 19:13TowRelationship addedrelated to 0001320
2022-04-11 17:49PovelitelStatusresolved => closed

Notes
(0003630)
amvmichael   
2013-06-02 11:30   
(edited on: 2013-06-02 12:29)
Actually no need to do anything. Just double clik on town, icon is fine too :P.
To avoid error: do not enter town, end turn then enter it on next turn :P.
(0003635)
Tow   
2013-06-02 14:24   
Hard to reproduce. It worked once for 4-5 attempts.

The stacktrace from dump:
> VCMI_lib.dll!CBuilding::getBase() Line 39 C++
     VCMI_client.exe!CBuildingRect::clickLeft(boost::logic::tribool down={...}, bool previousState=false) Line 105 C++
     VCMI_client.exe!CGuiHandler::handleEvent(SDL_Event * sEvent=0x069afa20) Line 277 C++
     VCMI_client.exe!CGuiHandler::handleEvents() Line 178 C++
     VCMI_client.exe!CPlayerInterface::update() Line 1573 C++
     VCMI_client.exe!CGuiHandler::run() Line 387 C++

Between getBase() and clickLeft() there is inlined getBuilding call. Looks as if str->building is null.
(0003643)
Ivan   
2013-06-02 18:35   
One yet again field not included serialization.
Was present for quite a while but due to my recent changes incorrect value (like one after loading) will now result in crash. :(
(0003644)
Ivan   
2013-06-02 18:59   
fixed, rev 3405
(0003704)
Zamolxis   
2013-06-11 17:12   
(edited on: 2013-06-13 09:51)
Temporary re-opening, this time for a 0.93 crash which may have the same cause:

- only on a loaded game (the VCMI_Tests map saved at start)
- going with Sir Mullich with Dimension Door (twice) South to conquer the Conflux
- after conquering, IF we use vcmiarmenelos and then enter town, the game crashes before the town screen appears.

Last message in the client log says something about sounds. Can it be same as this one? Do you need more details here? Or is it likely a different cause and I should open a separate report?

UPDATE: Added archive with save + crashdump so you can more easily check if it's the same or not.
(0003741)
Ivan   
2013-07-08 16:25   
Looks like the same one. Back to resolved.