MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001272VCMIGUI - Town screenpublic2013-05-27 13:432014-05-30 17:43
ReporterZamolxis 
Assigned ToIvan 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
Platformx86_64OSWindowsOS Version7 VAIO
Product Version0.92b 
Target VersionFixed in Version0.92c 
Summary0001272: Cannot build in town after loading
DescriptionLoad game from the first attachment. It's saved at game start, yet we can't build anything.

And we can't build after End Turn either anymore.

However during the End Turn game also crashes on AI move: sometimes fully, sometimes we get the crashdump message, but AI continues to play until my turn. When I get to my turn, I still can't build in towns. I force crashed the game at that stage - so you see in the screenshot two messages about the crashdump in the same time.

(possibly two unrelated bugs, but as there are few other crash reports lately, the one here may be duplicate > let me know if you prefer I create a separate report)
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0001281closed Tow Crash when building Tavern in Castle town on a loaded game 
Attached Files7z 2013-05-27_AfterLoadCantBuild.7z (147,284) 2013-05-27 13:43
https://bugs.vcmi.eu/file_download.php?file_id=1270&type=bug
jpg 2013-05-27_AICrashButContinues.jpg (480,991) 2013-05-27 13:44
https://bugs.vcmi.eu/file_download.php?file_id=1271&type=bug
jpg

7z 2013-05-27_AICrashButContinues.7z (212,175) 2013-05-27 13:45
https://bugs.vcmi.eu/file_download.php?file_id=1272&type=bug
Issue History
Date ModifiedUsernameFieldChange
2013-05-27 13:43ZamolxisNew Issue
2013-05-27 13:43ZamolxisFile Added: 2013-05-27_AfterLoadCantBuild.7z
2013-05-27 13:44ZamolxisFile Added: 2013-05-27_AICrashButContinues.jpg
2013-05-27 13:45ZamolxisFile Added: 2013-05-27_AICrashButContinues.7z
2013-05-27 13:55ZamolxisNote Added: 0003568
2013-05-27 13:56ZamolxisNote Edited: 0003568bug_revision_view_page.php?bugnote_id=3568#r2200
2013-05-27 14:04ZamolxisNote Edited: 0003568bug_revision_view_page.php?bugnote_id=3568#r2201
2013-05-27 14:24IvanNote Added: 0003570
2013-05-27 14:24IvanNote Edited: 0003570bug_revision_view_page.php?bugnote_id=3570#r2203
2013-05-27 23:13TowNote Added: 0003572
2013-05-29 12:50ZamolxisNote Added: 0003590
2013-05-29 12:50ZamolxisAssigned To => Ivan
2013-05-29 12:50ZamolxisSeveritymajor => crash
2013-05-29 12:50ZamolxisStatusnew => feedback
2013-05-29 12:50ZamolxisSummaryCannot build in town after loading + crash on AI turn => Cannot build in town after loading + crash on AI turn (0.92c UPDATE: Crash on build)
2013-05-29 12:50ZamolxisFile Added: 2013-05-29_CrashAtLoad.jpg
2013-05-29 12:50ZamolxisFile Deleted: 2013-05-29_CrashAtLoad.jpg
2013-05-29 12:51ZamolxisFile Added: 2013-05-29_BuildTavernCrash.jpg
2013-05-29 12:54ZamolxisFile Added: 2013-05-29_BuildTavernCrash.7z
2013-05-29 12:57ZamolxisNote Edited: 0003590bug_revision_view_page.php?bugnote_id=3590#r2218
2013-05-29 12:57ZamolxisFile Added: 2013-05-29_BuildTavernCrash2.jpg
2013-05-29 12:59ZamolxisNote Edited: 0003590bug_revision_view_page.php?bugnote_id=3590#r2219
2013-05-29 13:08ZamolxisCategoryMechanics - Town structures => GUI - Town screen
2013-05-29 17:28IvanNote Added: 0003592
2013-05-29 20:12IvanNote Added: 0003595
2013-05-29 20:12IvanAssigned ToIvan =>
2013-05-29 20:34ZamolxisNote Added: 0003596
2013-05-29 20:34ZamolxisStatusfeedback => new
2013-05-29 20:34ZamolxisStatusnew => resolved
2013-05-29 20:34ZamolxisResolutionopen => fixed
2013-05-29 20:34ZamolxisAssigned To => Ivan
2013-05-29 20:48ZamolxisIssue cloned: 0001281
2013-05-29 20:48ZamolxisRelationship addedrelated to 0001281
2013-05-29 20:49ZamolxisFile Deleted: 2013-05-29_BuildTavernCrash.7z
2013-05-29 20:49ZamolxisFile Deleted: 2013-05-29_BuildTavernCrash.jpg
2013-05-29 20:49ZamolxisFile Deleted: 2013-05-29_BuildTavernCrash2.jpg
2013-05-29 20:50ZamolxisNote Edited: 0003596bug_revision_view_page.php?bugnote_id=3596#r2224
2013-05-29 20:56ZamolxisSeveritycrash => major
2013-05-29 20:56ZamolxisSummaryCannot build in town after loading + crash on AI turn (0.92c UPDATE: Crash on build) => Cannot build in town after loading
2013-05-29 20:56ZamolxisFixed in Version => 0.92c
2014-05-30 17:43beegeeStatusresolved => closed

Notes
(0003568)
Zamolxis   
2013-05-27 13:55   
(edited on: 2013-05-27 14:04)
It would be nice if this can be fixed before 0.92c because if we can't build and AI crashes on their turn (and with 0001269 just fixed in dev), it's rather difficult to move on with the testing.
(0003570)
Ivan   
2013-05-27 14:24   
Town building should be OK now.

AI crash(es) are probably related to recent changes in queries by Tow so I'm leaving this report to him.
(0003572)
Tow   
2013-05-27 23:13   
I'm not seeing AI crashes with my working copy. Haven't tested much, debug builds are awfully slow.
Please try to catch reproducible scenario for AI crash with 0.92c. (I hope to post it within a day)
(0003590)
Zamolxis   
2013-05-29 12:50   
(edited on: 2013-05-29 12:59)
@Tow: The game doesn't crash on AI turn anymore in 0.92c, so that's solved.

@Ivan: We can build now, but the game crashes. Not in all cases, so I'm not sure if it's related to your fix. Let me know if not, in which case this I'll create a separate report. For now, I'm attaching here crash screenshot + 7z with logs, crashdump and save. It's the save at game start, so no action before. I can build in Tower, but if I try to build in the 2nd town (Castle), the only building still missing - Tavern - the game always crashes.

UPDATE: Crash is not always the same. In first screenshot you can see Tavern appeared just before the crash. I'm adding a 2nd screenshot where the crash happened before the Tavern appeared. Also showing Console message saying something about the Lighthouse, which may explain why it only crashes in this particular town. So it could be they are not related, in which case let me know if I should make a split report, and mark this as Resolved.
(0003592)
Ivan   
2013-05-29 17:28   
Most likely unrelated - original bug was due to "max buidings per turn" set to 0 instead of one.

Will check what's wrong here.
(0003595)
Ivan   
2013-05-29 20:12   
Reproducible, not related to original bug - something in bonus system (duplicate lighthouse bonus?)

Not sure what's going on here - can somebody familiar with bonus system check this?
Crash on server, stacktrace:
0 ?? 0x3266250
1 CBonusSystemNode::unpropagateBonus HeroBonus.cpp 817
2 CBonusSystemNode::removeBonus HeroBonus.cpp 783
3 CGTownInstance::recreateBuildingsBonuses CObjectHandler.cpp 2489
4 NewStructures::applyGs NetPacksLib.cpp 444
5 CApplyOnGS<NewStructures>::applyOnGS CGameState.cpp 72
6 CGameState::apply CGameState.cpp 1849
7 CGameHandler::sendAndApply CGameHandler.cpp 2150
8 CGameHandler::sendAndApply CGameHandler.cpp 2182
9 CGameHandler::buildStructure CGameHandler.cpp 2486
10 BuildStructure::applyGh NetPacksServer.cpp 113
11 CApplyOnGH<BuildStructure>::applyOnGH CGameHandler.cpp 87
(0003596)
Zamolxis   
2013-05-29 20:34   
(edited on: 2013-05-29 20:50)
Thanks. I'll create a separate report (0001281) with your findings above and move the logs & screenshots there.