MantisBT - VCMI
View Issue Details
0001133VCMIMechanics - Objectspublic2012-10-03 12:512014-05-30 17:43
Keloraen 
Warmonger 
normalminoralways
closedfixed 
0.9 
0.93 
0001133: Artifact disappears when combining units
When I trying to combine two units, if one of them has an artifact, then combined unit loses this artifact.
Translated from Russian (Ivan):
Load save file from attachment, open Christian hero screen, he has two stacks of Crossbowmen: 84 units and 10 units, stack have artifact (Golden Arrow IIRC). Try to merge stacks:
- merge 84 into 10, artefact in place
- merge 10 into 84, artefact is lost
Splitting troops works fine BTW. Only one stack have artifact after split.
No tags attached.
zip vcmi_bug_creature_artefact.zip (119,225) 2012-10-03 12:51
https://bugs.vcmi.eu/file_download.php?file_id=1142&type=bug
Issue History
2012-10-03 12:51KeloraenNew Issue
2012-10-03 12:51KeloraenFile Added: vcmi_bug_creature_artefact.zip
2012-10-03 14:14ZamolxisAssigned To => Ivan
2012-10-03 14:14ZamolxisStatusnew => assigned
2012-10-03 14:28WarmongerAssigned ToIvan => Warmonger
2012-10-03 14:28WarmongerNote Added: 0003159
2012-10-03 14:29WarmongerCategoryGUI - Hero screen / Exchange window => Mechanics - Objects
2012-10-03 20:38ZamolxisNote Added: 0003160
2012-10-03 20:41ZamolxisNote Edited: 0003160bug_revision_view_page.php?bugnote_id=3160#r1997
2012-10-03 21:05IvanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=1999#r1999
2012-10-03 21:05IvanAdditional Information Updatedbug_revision_view_page.php?rev_id=2001#r2001
2012-10-03 21:05IvanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=2002#r2002
2012-10-03 21:07IvanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=2003#r2003
2012-10-03 21:10IvanNote Added: 0003161
2012-10-03 21:14IvanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=2004#r2004
2012-10-04 04:26KeloraenNote Added: 0003162
2012-10-04 04:43KeloraenNote Edited: 0003162bug_revision_view_page.php?bugnote_id=3162#r2006
2012-10-04 04:45KeloraenNote Edited: 0003162bug_revision_view_page.php?bugnote_id=3162#r2007
2012-12-01 10:04WarmongerNote Added: 0003224
2012-12-01 10:49IvanNote Added: 0003225
2012-12-06 13:28AlexVinSNote Added: 0003236
2012-12-06 14:39WarmongerNote Added: 0003237
2012-12-06 14:43AlexVinSNote Added: 0003238
2013-03-05 07:37WarmongerNote Added: 0003435
2013-03-05 07:37WarmongerStatusassigned => resolved
2013-03-05 07:37WarmongerFixed in Version => 0.93
2013-03-05 07:37WarmongerResolutionopen => fixed
2014-05-30 17:43beegeeStatusresolved => closed

Notes
(0003159)
Warmonger   
2012-10-03 14:28   
What should be default behaviour?
(0003160)
Zamolxis   
2012-10-03 20:38   
(edited on: 2012-10-03 20:41)
Ah yes, I figured it out... at least I think that's what the report is about: if you give Warlord's Banner to a stack, then merge that stack into another, the the Banner is lost.

The Russian text confused me initially (hence me assigning this to Ivan, so he can help translating), because Google Translate found something like "golden arrow". Or can we give creatures other artifacts than the banner?

(0003161)
Ivan   
2012-10-03 21:10   
Translated, assigned back to Warmonger.

Notes:
- not sure what "lost" means - artifact may be removed completely from game or just moved to hero (lost from creature).
- not sure if both stacks have artifacts or only one of them have it

@Zamolxis
IIRC vcmi have some more stack artifacts apart from banner.
(0003162)
Keloraen   
2012-10-04 04:26   
(edited on: 2012-10-04 04:45)
2 Ivan
Спасибо за перевод. Просто вчера на работе времени не хватило=)
Thanks for the translation. I did not translate, because the working time was over=)

I did not try to reproduce this operation with Warlord's Banner. I find Golden Arrow on the adventure map and give it to Crossbowmen. However I think Warlord's Banner should not be lost from creature too. Isn't it?

(0003224)
Warmonger   
2012-12-01 10:04   
I mean, what should happen if BOTH stacks have an artifact? Certainly only one of them can be active at time.
(0003225)
Ivan   
2012-12-01 10:49   
Why not drop artifact to hero inventory?

Garrisoned armies without hero would need another solution. Removing artifact from game should be fine as long as confirmation yes/no message is there.
(0003236)
AlexVinS   
2012-12-06 13:28   
In WoG creature may have more than 1 art (but of course only only one is active).
But I think it`s better to move art to inventory if we don`t plan to support more than 1 active creature art.
(0003237)
Warmonger   
2012-12-06 14:39   
I'd like to avoid storing additional artifacts on stacks, as artifact system is already complex and causes troubles.

Another issue is what to do when two stacks, each with artifact, are merged. Which one to choose?
(0003238)
AlexVinS   
2012-12-06 14:43   
>Another issue is what to do when two stacks, each with artifact, are merged. >Which one to choose?

Ask player if artifacts are different.
(0003435)
Warmonger   
2013-03-05 07:37   
Fixed in r3270. No artifact selection dialog yet, but at least artifacts won't be lost.