MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000111VCMIMechanics - Otherpublic2009-10-04 12:552009-12-23 01:16
ReporterSteven Aus 
Assigned ToWarmonger 
PrioritynormalSeverityfeatureReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version0.74 
Target VersionFixed in Version0.75 
Summary0000111: No +1 bonus growth in town for matching external flagged dwellings yet.
DescriptionI think it's worth putting in with Severity as "feature" now, even though it's definitely going to be implemented sooner or later. =)
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0000318closed Warmonger The Grail growth bonus seems to apply only to Castle growth, not also to flagged dwellings, horde structures, etc 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-10-04 12:55Steven AusNew Issue
2009-10-24 12:14WarmongerStatusnew => assigned
2009-10-24 12:14WarmongerAssigned To => Warmonger
2009-10-26 09:08WarmongerNote Added: 0000160
2009-10-26 09:08WarmongerStatusassigned => resolved
2009-12-22 17:08ZamolxisNote Added: 0000464
2009-12-22 17:08ZamolxisStatusresolved => feedback
2009-12-22 17:08ZamolxisResolutionopen => reopened
2009-12-22 17:09ZamolxisNote Edited: 0000464bug_revision_view_page.php?bugnote_id=464#r472
2009-12-22 19:32IvanNote Added: 0000466
2009-12-22 22:04ZamolxisNote Edited: 0000464bug_revision_view_page.php?bugnote_id=464#r478
2009-12-23 01:15ZamolxisNote Added: 0000476
2009-12-23 01:15ZamolxisStatusfeedback => closed
2009-12-23 01:15ZamolxisResolutionreopened => fixed
2009-12-23 01:15ZamolxisFixed in Version => 0.75
2009-12-23 01:16ZamolxisRelationship addedrelated to 0000318

Notes
(0000160)
Warmonger   
2009-10-26 09:08   
Handled and tested, however I'm not sure if all issues concenring dwellings are organized properly.
(0000464)
Zamolxis   
2009-12-22 17:08   
(edited on: 2009-12-22 22:04)
It is still behaving differently then H3, however I wonder if the H3 behavior was not actually buggy. Namely, in H3, every second dwelling flagged of that type, was giving +2 bonus i/o +1. That means in H3 the 1st, 3rd, 5th, etc dwelling flagged were giving +1 bonuses. But the 2nd, 4th, 6th, etc dwellings flagged were giving +2 bonuses.

I guess we need to decide if we should consider the H3 behavior buggy or not, and see if we leave VCMI as it is, or implement the same.

EDIT: Thanks to Ivan's comment below, this clears out the H3 behavior. Namely that the Grail gives the 50% bonus all together. So 2 flagged dwellings give only +2, but the Grail makes that +3. So I guess it's not really a H3 bug, but perhaps a feature which should be implemented in VCMI as well. No change in the code for the flagged dwellings necessary, just in the code of the Grail, to make it the final bonus.
(0000466)
Ivan   
2009-12-22 19:32   
Strange - just checked H3 behavior and this part looks to be identical to VCMI - each dwelling gives only +1 bonus.
Onlyth way for me to get such bonus - is build grail (+50% to ALL growth). In this case - for each 2nd dwelling we'll receive +1 bonus from grail
(0000476)
Zamolxis   
2009-12-23 01:15   
Again, as mentioned above, thanks to Ivan's comment, it has been confirmed that the bug reported here has been properly fixed. The fact that the Grail bonus applies to flagged dwellings as well it's a different issue, and I've reported that separately as 0000318 (describing in details how all these growth bonuses should work).

Closed as fixed.