MantisBT - VCMI
View Issue Details
0000109VCMIGUI - Otherpublic2009-10-04 12:402010-07-04 12:18
Tow dragon 
Tow 
lowtweakhave not tried
closedfixed 
0.73 
0.8 
0000109: Ships do not correspond to their alignments.
0.73#81 - Ships do not correspond to their alignments.

In VCMI all Build Ship screens display the same boat, and the built boats are the same. However H3 has 3 different boats:

1) - The "default" Ship. It's the one that we have now in VCMI. This is the default H3 boat that we should be getting at Castle and from the Adv.Map Shipyards.

2) - The "Ghost" Ship, which should be given at Necropolis:
http://s4.photobucket.com/albums/y104/Zamolxis/VCMI/VCMI%2007/?action=view&current=2009-09-12_H3NecroShip.jpg [^]

3) - And the Vessel (or Craft?), which should be given at Fortress:
http://s4.photobucket.com/albums/y104/Zamolxis/VCMI/VCMI%2007/?action=view&current=2009-09-12_H3FortressShip.jpg [^]

DEVELOPMENT NOTES:

a) Conflux did not come with a ship of its own. The Shipyard screen was showing the Necro Ship, after buying it the Castle Ship was popping on the Adventure Map, while the cartoonish ship that was created in the town screen looked nothing like either of the two. As that didn't make much sense (one of the rushed elements of the AB release), I guess in VCMI we need to make a decision on it. The Necro ship definitely has no place there (it looks like either a Ghost ship, or else a burned out ship, which could also suit Inferno or Dungeon at best, but that's it). So the choice is between the Castle and the Fortress ship. The Castle one would be okay, unless we want to associate the 3 ships with the 3 alignment groups - Good/Evil/Neutral - in which case Conflux should get the same boat as Fortress. Or else design a new ship tailored for the alignment. But that's already modding I guess.

b) Summon Boat. I ran some tests in H3, and the spell does not seem to be associate with hero's alignment: hero summons always the closest empty boat and if no boat on the map, then they summon the Ghost Ship (I guess it somehow makes sense as it's summoned out of nowhere). This is FYI - I guess we can still decide if we want to associate boats with alignments or not. In case we would, when no boats on the map (or 2 equally far), heroes would summon a certain preferred boat. But that's just an idea, we can also leave things like in H3 from this perspective.

c) H3 was providing the same boat type (Castle) on the Adventure Map for all town shipyards. So even if Necro & Fortress were displaying their boats in the Buy Ship screen, after exiting town, the Castle ship was in front of it. This was IMO a minor bug in H3, and not an intended feature, so I don't think we need to repeat in VCMI. But same as the other points, I guess this is a decision for the devs.

[If anybody has other info regarding NWC's further purposes for the 3 boat types, please share]
Originally reported here: http://forum.vcmi.eu/viewtopic.php?p=3577#3577 [^]
No tags attached.
related to 0000359closed Tow Crash when trying to buy a ship at Necropolis, Fortress or Conflux 
Issue History
2009-10-04 12:40Tow dragonNew Issue
2009-10-27 17:44WarmongerAssigned To => Warmonger
2009-10-27 17:44WarmongerStatusnew => assigned
2009-10-27 20:27ZamolxisDescription Updatedbug_revision_view_page.php?rev_id=301#r301
2009-10-28 10:43WarmongerNote Added: 0000163
2009-10-28 11:32WarmongerNote Edited: 0000163bug_revision_view_page.php?bugnote_id=163#r320
2009-10-30 22:25ZamolxisNote Added: 0000166
2010-01-03 11:06WarmongerNote Added: 0000565
2010-01-03 11:17WarmongerNote Added: 0000566
2010-01-03 11:17WarmongerStatusassigned => resolved
2010-01-03 11:17WarmongerFixed in Version => 0.89
2010-01-03 11:17WarmongerResolutionopen => fixed
2010-02-13 00:42ZamolxisRelationship addedrelated to 0000359
2010-02-13 00:46ZamolxisNote Added: 0000650
2010-02-13 00:46ZamolxisStatusresolved => feedback
2010-02-13 00:46ZamolxisResolutionfixed => reopened
2010-02-13 00:46ZamolxisNote Edited: 0000650bug_revision_view_page.php?bugnote_id=650#r572
2010-02-13 04:49TowNote Added: 0000653
2010-02-13 04:49TowStatusfeedback => resolved
2010-02-13 04:49TowResolutionreopened => fixed
2010-02-13 04:55TowStatusresolved => assigned
2010-02-13 04:55TowAssigned ToWarmonger => Tow
2010-02-13 04:55TowStatusassigned => resolved
2010-05-29 21:47ZamolxisProduct Version => 0.73
2010-05-29 21:47ZamolxisDescription Updatedbug_revision_view_page.php?rev_id=799#r799
2010-05-29 21:48ZamolxisDescription Updatedbug_revision_view_page.php?rev_id=800#r800
2010-07-04 09:22ZamolxisNote Added: 0001012
2010-07-04 09:22ZamolxisStatusresolved => closed

Notes
(0000163)
Warmonger   
2009-10-28 10:43   
(edited on: 2009-10-28 11:32)
I've made some improvements, but have no idea how town alignment is processed (if at all).

(0000166)
Zamolxis   
2009-10-30 22:25   
Looks like NWC planned to associate the boats with the alignments, but it seems they never completed that part of the code. About Necro & Fortress it's quite obvious. It's mainly Conflux for which we'll need to take a decision ourselves. But we'll see in the next release what we have after the improvements you mention and we'll take it from there.
(0000565)
Warmonger   
2010-01-03 11:06   
I've found effective (but not simplest) way to determine type of the ship depending of alignment of creatures avaliable in the town - so possibly it will work also for new towns added in the future.
(0000566)
Warmonger   
2010-01-03 11:17   
Fixed in r1406
(0000650)
Zamolxis   
2010-02-13 00:46   
Ships still don't correspond to their alignments in 0.75c, if I open the Shipyard screen in towns. It only corresponds for Castle, the only one where I can also buy the ship. For the others the game crashes (see 0000359).

(0000653)
Tow   
2010-02-13 04:49   
Fixed in 1483.
Both for Shipyard window and ships appearing on advmap.
(0001012)
Zamolxis   
2010-07-04 09:22   
Verified as fixed in 0.81