MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001071VCMIGUI - Adventure Mappublic2012-09-09 07:422014-05-30 17:41
ReporterZamolxis 
Assigned ToTow 
PrioritynormalSeveritycrashReproducibilityalways
StatusclosedResolutionfixed 
Platformx86_64OSWindowsOS Version7 VAIO
Product Version0.89b 
Target VersionFixed in Version0.9 
Summary0001071: Game crashes when going to Full Screen from Adventure map
DescriptionAs the summary says, this happens only when we're on Adventure map (from battles it works fine, and from Main Menu the feature is not implemented yet).

Two different types of crashes, depending on how we try to enable full screen:

1. If we try from System Options, the resolution of our desktop changes, but the client interface appears totally out of focus (its upper left corner close to the center of our screen). Soon after it also gets the "(Not Responding)" text in the title bar. Crash dump is not automatically created, so I had to force it (see first 2 attachments). Next time we launch the application, the client is still in windowed mode.

2. If we try using F4, the Adventure map does go to a properly centered full screen, but the game crashes as soon as we try to do any action. Crashdump automatically created now (see next 2 attachments). When we launch the application again, this time the full screen mode setting is saved and working correctly. [In this case we also lose control of the mouse: I was not able to use it to move the Crashhandler box above the console, or to access my usual screen capture application - I had to use the PrintScreen button on my keyboard, and then kill the app, in order to go to an image editor to crop & save the screenshot]

Note: going back from full screen to windowed mode does not lead to similar crashes.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0001108closed  Alt-Tab + F4 issues 
Attached Files7z 2012-09-09_FullScreenCrashForcedDump.7z (124,450) 2012-09-09 07:44
https://bugs.vcmi.eu/file_download.php?file_id=1070&type=bug
jpg 2012-09-09_FullScreenCrashForcedDump.jpg (114,408) 2012-09-09 07:44
https://bugs.vcmi.eu/file_download.php?file_id=1071&type=bug
jpg

7z 2012-09-09_F4Crash.7z (122,712) 2012-09-09 07:45
https://bugs.vcmi.eu/file_download.php?file_id=1072&type=bug
jpg 2012-09-09_F4Crash.jpg (123,750) 2012-09-09 07:45
https://bugs.vcmi.eu/file_download.php?file_id=1073&type=bug
jpg
Issue History
Date ModifiedUsernameFieldChange
2012-09-09 07:42ZamolxisNew Issue
2012-09-09 07:44ZamolxisFile Added: 2012-09-09_FullScreenCrashForcedDump.7z
2012-09-09 07:44ZamolxisFile Added: 2012-09-09_FullScreenCrashForcedDump.jpg
2012-09-09 07:45ZamolxisFile Added: 2012-09-09_F4Crash.7z
2012-09-09 07:45ZamolxisFile Added: 2012-09-09_F4Crash.jpg
2012-09-09 07:50ZamolxisDescription Updatedbug_revision_view_page.php?rev_id=1900#r1900
2012-09-09 08:45IvanNote Added: 0003001
2012-09-09 23:49TowNote Added: 0003005
2012-09-10 00:01TowNote Added: 0003006
2012-09-10 00:02TowAssigned To => Tow
2012-09-10 00:02TowStatusnew => assigned
2012-09-11 14:27TowNote Added: 0003007
2012-09-11 14:27TowStatusassigned => resolved
2012-09-11 14:27TowFixed in Version => 0.9
2012-09-11 14:27TowResolutionopen => fixed
2012-09-29 21:19ZamolxisIssue cloned: 0001108
2012-09-29 21:19ZamolxisRelationship addedrelated to 0001108
2014-05-30 17:41beegeeStatusresolved => closed

Notes
(0003001)
Ivan   
2012-09-09 08:45   
This version is full of non-reproducible for me bugs...

In case if other devs will be more luckily with reproducing.
May be caused by multithreading:
Input handling thread is in the middle of toggling fullscreen.
Gui handling thread is in the middle of blitting on screen.
(0003005)
Tow   
2012-09-09 23:49   
This issue is indeed strange. I started debug version, pressed F4 ang got immediate crash... However I couldn't switch back to the Visual Studio and debug it, since crashed VCMI went fullscreeen and were kinda blocking everything. I closed VCMI... and when I tried this second time, multiple pressing F4 did not crash.

>"May be caused by multithreading:
Input handling thread is in the middle of toggling fullscreen.
Gui handling thread is in the middle of blitting on screen. "

It is not the case, crash is happening after the new screen is created. The CPlayerInterface::pim mutex prevents (or at least should prevent) the case you described.
(0003006)
Tow   
2012-09-10 00:01   
Reproduced and thought it was fixed by r2877 but not entirely.
I'll finish this later.
(0003007)
Tow   
2012-09-11 14:27   
Should be fully fixed in r2878.