MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001059VCMIGUI - Battlespublic2012-08-28 15:582023-01-09 20:15
ReporterIvan 
Assigned ToIvan 
PrioritynormalSeveritytweakReproducibilityalways
StatusresolvedResolutionfixed 
Platformx86_64OSUbuntu LinuxOS Version12.04 (precise)
Product Version 
Target VersionFixed in Version 
Summary0001059: Heroes during battle no longer have flags
DescriptionJust noticed - flags that heroes should hold during battle are missing. Instead they are holdings empty flagpole.

Looks to be bug - old VCMI screenshots had them.
Steps To Reproduce
Additional InformationScreenshot (if needed) here: http://forum.vcmi.eu/download.php?id=444 [^]
TagsNo tags attached.
Relationships
related to 0001834new  (Tavern window) Some GUI elements disappear when popup window is opened. 
Attached Filespng no flag.png (564,610) 2014-08-09 07:48
https://bugs.vcmi.eu/file_download.php?file_id=1878&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2012-08-28 15:58IvanNew Issue
2012-08-28 16:31IvanAdditional Information Updatedbug_revision_view_page.php?rev_id=1860#r1860
2012-08-29 13:16TowNote Added: 0002947
2012-08-29 13:16TowAssigned To => Ivan
2012-08-29 13:16TowStatusnew => feedback
2012-08-29 13:28IvanStatusfeedback => assigned
2012-08-29 13:41IvanNote Added: 0002949
2012-08-29 14:56IvanNote Added: 0002950
2012-08-29 14:56IvanStatusassigned => resolved
2012-08-29 14:56IvanFixed in Version => 0.9
2012-08-29 14:56IvanResolutionopen => fixed
2014-05-30 17:41beegeeStatusresolved => closed
2014-08-09 07:47KantorNote Added: 0004908
2014-08-09 07:47KantorStatusclosed => feedback
2014-08-09 07:47KantorResolutionfixed => reopened
2014-08-09 07:48KantorFile Added: no flag.png
2014-08-09 10:21IvanNote Added: 0004909
2014-08-09 10:21IvanStatusfeedback => assigned
2014-08-09 11:02KantorNote Edited: 0004908bug_revision_view_page.php?bugnote_id=4908#r2614
2016-08-28 04:10SXXAssigned ToIvan => SXX
2016-09-12 03:02SXXNote Added: 0006652
2016-09-12 03:02SXXStatusassigned => confirmed
2016-09-12 03:03SXXRelationship addedrelated to 0001834
2022-12-17 17:09IvanAssigned ToSXX => Ivan
2022-12-17 17:09IvanStatusconfirmed => assigned
2022-12-17 17:13IvanStatusassigned => confirmed
2023-01-09 20:15IvanNote Added: 0008434
2023-01-09 20:15IvanStatusconfirmed => resolved
2023-01-09 20:15IvanFixed in Version0.9 =>
2023-01-09 20:15IvanResolutionreopened => fixed

Notes
(0002947)
Tow   
2012-08-29 13:16   
It's transparency handling.

In CBattleHero constructor the line:
graphics->blueToPlayersAdv(flag->ourImages[i].bitmap, player);

replaces default, blue colors with player colors in flag. However they all seem to have alpha value of 0, which now is transparent for our blitting procedure.
I'm not sure how it should be fixed though, you may have a better idea of the code.
(0002949)
Ivan   
2012-08-29 13:41   
Ah. Found it.

But animation looks a bit weird. Maybe it is just too fast. Will commit fix a bit later.
(0002950)
Ivan   
2012-08-29 14:56   
Fixed in rev 2860.
(0004908)
Kantor   
2014-08-09 07:47   
(edited on: 2014-08-09 11:02)
This one seems to be back with SDL 2.
EDIT: I forgot to say that it seems to occurs only while viewing creature info.
(0004909)
Ivan   
2014-08-09 10:21   
For me it works. And in this case I don't see any suspicious code.

AVS, can you take a look at this?
(0006652)
SXX   
2016-09-12 03:02   
This is still there and it's related to other problems with UI.
When there is some element on top flag become invisible.
(0008434)
Ivan   
2023-01-09 20:15   
Resolved in PR 1229. Will be released as 1.2