|Anonymous | Login | Signup for a new account||2013-05-24 15:49 CEST|
|Main | My View | View Issues | Change Log | Roadmap|
|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0000982||VCMI||GUI - Battles||public||2012-05-27 12:20||2012-05-27 16:08|
|Priority||normal||Severity||minor||Reproducibility||have not tried|
|Target Version||Fixed in Version||0.89|
|Summary||0000982: Borders around creature portraits in stack queue are not visible|
|Description||Start battle using resolution higher than 800x600, so the full version of stack queue is present. It displays its background and creatures but it's missing background ( CHRROP.pcx ).|
The problem seems related to recent blitting reorganziation.
In the CStackQueue::StackBox::showAll method the line:
CSDL_Ext::blit8bppAlphaTo24bpp(bg, NULL, to, &temp_rect);
is supposed to blit border image.
However, if you test it (ie. by putting SDL_SaveBMP(to, "to.bmp") after it) it apparently is still not visible.
If I comment out the blit8bppAlphaTo24bpp line and restore the following blitAt line, issue is gone. It is not what I would expect. I suspect it may be 0/255 opaque/transparent interpretation mismatch.
|Tags||No tags attached.|
Interesting. I've changed alpha to match values in SDL:
#define SDL_ALPHA_OPAQUE 255
#define SDL_ALPHA_TRANSPARENT 0
But indexed images loaded via SDL have color.unused set to zero. I suppose we have to set it manually.
I agree that blit8to24 is broken (will fix) but why you're using it here? If blitting via SDL works we should use it instead.
> I agree that blit8to24 is broken (will fix) but why you're using it here? If blitting via SDL works we should use it instead.
You're right, there is no good reason to use 8to24 blit there. I'll change that later. Consider this report to be about alpha values mismatch in our graphics. I just noticed the issue on that particular example. :)
|fixed in rev 2721|
|2012-05-27 12:20||Tow||New Issue|
|2012-05-27 12:20||Tow||Status||new => assigned|
|2012-05-27 12:20||Tow||Assigned To||=> Ivan|
|2012-05-27 12:20||Tow||Product Version||0.89 => 0.dev|
|2012-05-27 13:52||Ivan||Note Added: 0002571|
|2012-05-27 15:23||Tow||Note Added: 0002572|
|2012-05-27 16:08||Ivan||Note Added: 0002573|
|2012-05-27 16:08||Ivan||Status||assigned => resolved|
|2012-05-27 16:08||Ivan||Fixed in Version||=> 0.89|
|2012-05-27 16:08||Ivan||Resolution||open => fixed|
|Copyright © 2000 - 2012 MantisBT Group|