MantisBT

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001264VCMIGUI - Battlespublic2013-04-27 06:422014-05-30 17:43
ReporterWarmonger 
Assigned ToTow 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version0.92 
Target Version0.93Fixed in Version0.93 
Summary0001264: ONLY_ENEMY_ARMY bonus range does not work
DescriptionAll bonuses with this range don't work in battle, unfortunatelly. It seems that they are corrctly attached to battle node, but for some reason are not visible in game.
Steps To ReproduceUse attached map and enter battle with Arch Devil / Ghost Dragon. Check enemy luck and morale which should be reduced by 1, but are not.
TagsNo tags attached.
Attached Files? file icon Testy12 abilities.h3m [^] (9,128 bytes) 2013-04-27 06:42

- Relationships

-  Notes
(0003539)
Tow (developer)
2013-05-19 20:34

Spent so much time on debugging bonus system and it was a trival bug — window used CStackInstance to print morale/luck, not the CStack… The bonuses worked fine all the time. Life is so cruel.

Fixed in r3378.
(0003540)
Warmonger (administrator)
2013-05-20 10:48

You say so? I noticed that finally artifacts with ONLY_ENEMY_ARMY work as expected, but they have nothing to do with morale.
(0003541)
Tow (developer)
2013-05-20 10:51

I checked the Ghost Dragon / Arch Devil and it works for me.
Let me know if there is any counter-case.
ONLY_ENEMY_ARMY is a terrible workaround that shouldn't be part of bonus system at all. (Yet it is damn useful so can't be removed.) There might be a case where it causes issue, but this bug isn't a one.
(0003542)
Warmonger (administrator)
2013-05-20 10:53

I mean, it did not work before, after recent commit it does. So it doesn't seem to be only issue with window, something else has changed in the meantime.
(0003543)
Tow (developer)
2013-05-20 10:58

It did work. Well, almost. Ghost Dragon was buggy due to 2 bugs:
1 entry in ZCRTRAIT was bugfully interpreted as +1 to morale (I fixed to -1)
2 you added entry to JSON config that gave -1 to morale (I commented it out)

Neither of bonuses was visible in the creature window and their sum was 0, so mechanically there was no visisble change to morale.

Still, the issues were unrelated to ONLY_ENEMY_ARMY. ;)

- Issue History
Date Modified Username Field Change
2013-04-27 06:42 Warmonger New Issue
2013-04-27 06:42 Warmonger File Added: Testy12 abilities.h3m
2013-04-27 06:46 Warmonger Steps to Reproduce Updated View Revisions
2013-05-19 20:34 Tow Note Added: 0003539
2013-05-19 20:34 Tow Status new => resolved
2013-05-19 20:34 Tow Fixed in Version => 0.93
2013-05-19 20:34 Tow Resolution open => fixed
2013-05-19 20:34 Tow Assigned To => Tow
2013-05-19 20:34 Tow Category Mechanics - Battles => GUI - Battles
2013-05-20 10:48 Warmonger Note Added: 0003540
2013-05-20 10:51 Tow Note Added: 0003541
2013-05-20 10:53 Warmonger Note Added: 0003542
2013-05-20 10:58 Tow Note Added: 0003543
2014-05-30 17:43 beegee Status resolved => closed

Site | Forums | Wiki | Slack | GitHub


Copyright © 2000 - 2024 MantisBT Team
Hosting provided by DigitalOcean