MantisBT

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001133VCMIMechanics - Objectspublic2012-10-03 12:512014-05-30 17:43
ReporterKeloraen 
Assigned ToWarmonger 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version0.9 
Target VersionFixed in Version0.93 
Summary0001133: Artifact disappears when combining units
DescriptionWhen I trying to combine two units, if one of them has an artifact, then combined unit loses this artifact.
Steps To ReproduceTranslated from Russian (Ivan):
Load save file from attachment, open Christian hero screen, he has two stacks of Crossbowmen: 84 units and 10 units, stack have artifact (Golden Arrow IIRC). Try to merge stacks:
- merge 84 into 10, artefact in place
- merge 10 into 84, artefact is lost
Additional InformationSplitting troops works fine BTW. Only one stack have artifact after split.
TagsNo tags attached.
Attached Fileszip file icon vcmi_bug_creature_artefact.zip [^] (119,225 bytes) 2012-10-03 12:51

- Relationships

-  Notes
(0003159)
Warmonger (administrator)
2012-10-03 14:28

What should be default behaviour?
(0003160)
Zamolxis (viewer)
2012-10-03 20:38
edited on: 2012-10-03 20:41

Ah yes, I figured it out... at least I think that's what the report is about: if you give Warlord's Banner to a stack, then merge that stack into another, the the Banner is lost.

The Russian text confused me initially (hence me assigning this to Ivan, so he can help translating), because Google Translate found something like "golden arrow". Or can we give creatures other artifacts than the banner?

(0003161)
Ivan (developer)
2012-10-03 21:10

Translated, assigned back to Warmonger.

Notes:
- not sure what "lost" means - artifact may be removed completely from game or just moved to hero (lost from creature).
- not sure if both stacks have artifacts or only one of them have it

@Zamolxis
IIRC vcmi have some more stack artifacts apart from banner.
(0003162)
Keloraen (reporter)
2012-10-04 04:26
edited on: 2012-10-04 04:45

2 Ivan
Спасибо за перевод. Просто вчера на работе времени не хватило=)
Thanks for the translation. I did not translate, because the working time was over=)

I did not try to reproduce this operation with Warlord's Banner. I find Golden Arrow on the adventure map and give it to Crossbowmen. However I think Warlord's Banner should not be lost from creature too. Isn't it?

(0003224)
Warmonger (administrator)
2012-12-01 10:04

I mean, what should happen if BOTH stacks have an artifact? Certainly only one of them can be active at time.
(0003225)
Ivan (developer)
2012-12-01 10:49

Why not drop artifact to hero inventory?

Garrisoned armies without hero would need another solution. Removing artifact from game should be fine as long as confirmation yes/no message is there.
(0003236)
AlexVinS (developer)
2012-12-06 13:28

In WoG creature may have more than 1 art (but of course only only one is active).
But I think it`s better to move art to inventory if we don`t plan to support more than 1 active creature art.
(0003237)
Warmonger (administrator)
2012-12-06 14:39

I'd like to avoid storing additional artifacts on stacks, as artifact system is already complex and causes troubles.

Another issue is what to do when two stacks, each with artifact, are merged. Which one to choose?
(0003238)
AlexVinS (developer)
2012-12-06 14:43

>Another issue is what to do when two stacks, each with artifact, are merged. >Which one to choose?

Ask player if artifacts are different.
(0003435)
Warmonger (administrator)
2013-03-05 07:37

Fixed in r3270. No artifact selection dialog yet, but at least artifacts won't be lost.

- Issue History
Date Modified Username Field Change
2012-10-03 12:51 Keloraen New Issue
2012-10-03 12:51 Keloraen File Added: vcmi_bug_creature_artefact.zip
2012-10-03 14:14 Zamolxis Assigned To => Ivan
2012-10-03 14:14 Zamolxis Status new => assigned
2012-10-03 14:28 Warmonger Assigned To Ivan => Warmonger
2012-10-03 14:28 Warmonger Note Added: 0003159
2012-10-03 14:29 Warmonger Category GUI - Hero screen / Exchange window => Mechanics - Objects
2012-10-03 20:38 Zamolxis Note Added: 0003160
2012-10-03 20:41 Zamolxis Note Edited: 0003160 View Revisions
2012-10-03 21:05 Ivan Steps to Reproduce Updated View Revisions
2012-10-03 21:05 Ivan Additional Information Updated View Revisions
2012-10-03 21:05 Ivan Steps to Reproduce Updated View Revisions
2012-10-03 21:07 Ivan Steps to Reproduce Updated View Revisions
2012-10-03 21:10 Ivan Note Added: 0003161
2012-10-03 21:14 Ivan Steps to Reproduce Updated View Revisions
2012-10-04 04:26 Keloraen Note Added: 0003162
2012-10-04 04:43 Keloraen Note Edited: 0003162 View Revisions
2012-10-04 04:45 Keloraen Note Edited: 0003162 View Revisions
2012-12-01 10:04 Warmonger Note Added: 0003224
2012-12-01 10:49 Ivan Note Added: 0003225
2012-12-06 13:28 AlexVinS Note Added: 0003236
2012-12-06 14:39 Warmonger Note Added: 0003237
2012-12-06 14:43 AlexVinS Note Added: 0003238
2013-03-05 07:37 Warmonger Note Added: 0003435
2013-03-05 07:37 Warmonger Status assigned => resolved
2013-03-05 07:37 Warmonger Fixed in Version => 0.93
2013-03-05 07:37 Warmonger Resolution open => fixed
2014-05-30 17:43 beegee Status resolved => closed

Site | Forums | Wiki | Slack | GitHub


Copyright © 2000 - 2024 MantisBT Team
Hosting provided by DigitalOcean