MantisBT - VCMI
View Issue Details
0000944VCMIGUI - Otherpublic2012-04-23 21:022016-01-17 12:33
greg3ll 
SXX 
lowminoralways
closedfixed 
pcwin 7x64
0.88 
0.97b 
0000944: Clk on save name gets last save from list
On save game screen, when clicking on save name area, the text of last save from list is taken. to be honest, i'm not sure if last or just closest one - to check with longer saves list.
enter to save game screen, enter some name, click on it and this is it.
No tags attached.
png s04.png (327,795) 2012-04-23 21:02
https://bugs.vcmi.eu/file_download.php?file_id=919&type=bug
png
Issue History
2012-04-23 21:02greg3llNew Issue
2012-04-23 21:02greg3llFile Added: s04.png
2012-04-23 23:23ZamolxisNote Added: 0002386
2014-11-23 02:16SXXNote Added: 0005152
2014-11-23 02:16SXXStatusnew => confirmed
2014-11-23 03:32SXXNote Added: 0005153
2014-11-23 06:06SXXNote Added: 0005154
2014-11-23 06:14SXXAssigned To => SXX
2014-11-23 06:14SXXStatusconfirmed => assigned
2014-11-23 09:43WarmongerNote Added: 0005155
2014-11-23 09:44WarmongerNote Edited: 0005155bug_revision_view_page.php?rev_id=2726
2014-11-23 09:45WarmongerNote Deleted: 0005155
2014-11-23 09:50SXXNote Added: 0005156
2014-11-23 09:57SXXStatusassigned => resolved
2014-11-23 09:57SXXFixed in Version => 0.97b
2014-11-23 09:57SXXResolutionopen => fixed
2014-11-23 11:08WarmongerNote Added: 0005157
2016-01-17 12:33SXXStatusresolved => closed

Notes
(0002386)
Zamolxis   
2012-04-23 23:23   
It's best to test with 18 saved games or more. The behavior seems to be as follows:
- while the visible list has 16 lines, the client seems to read 2 more below when it comes to clicking with the mouse - so if you click between the 16th and Save Name area it picks the 17th (that normally you should scroll for), and if you click even lower, in the Save Name, it picks the 18th.
- if there are less the 1, respectively 2 lines to scroll below, then the game just picks the lowest available on top of that, when we click on the bar between, respectively on the Save Name area.
(0005152)
SXX   
2014-11-23 02:16   
This one still occur in 0.97 / git and very annoying.
(0005153)
SXX   
2014-11-23 03:32   
This does happen because "SelectionTab::getLine" of /client/CPreGame.cpp:1583 use same coordinates for all scenes where it's used while save game screen have less visible items in list.

Solution would be adding check of scene in :"getLine" and choose different coordinates depend on scene or explicitly deny clicks on save name area that possible let implement it without changing "getLine".
(0005154)
SXX   
2014-11-23 06:06   
Pull request:
https://github.com/vcmi/vcmi/pull/60 [^]
(0005156)
SXX   
2014-11-23 09:50   
@Warmonger can you please say why you deleted comment about it?
I just worried I missed something important. :-)
(0005157)
Warmonger   
2014-11-23 11:08   
Nah, was just tired.