|
Notes |
|
|
(0001395)
|
|
Ivan
|
|
2010-11-15 14:15
|
|
|
While text below the button is definitely a bug, text position works as intended. The idea was to have not only components adjusted but their subtitles as well. Do you think that placing them immediately below icon is better? |
|
|
|
|
Placing them immediately below artifact icon is H3 compliant. See H3 screenshot. I find it was perfectly aligned until 0.82 (check 2nd screenshot, where you can see also that the artifact icon was placed a little higher).
If for any reason you want to place the artifact icon or text a little lower than in 0.82, then the window has to definitely enlarge (it was a bit wider in H3 anyway as you can see), so that the name of the artifact can fit on 2 rows only. |
|
|
|
(0001472)
|
|
Ivan
|
|
2011-01-01 20:34
|
|
|
Should be fixed in rev 1907 |
|
|
|
(0001614)
|
|
Zamolxis
|
2011-03-03 22:50
(edited on: 2011-03-03 22:58) |
|
Only halfway fixed (only the text moved under artifact icon).
But the icon (together with the text) has to move as well further up, with about the same number of pixels as you moved the text only.
Look at the 2nd screenshot (from 0.82) - that was the best we had so far. And if you see the 0.84 I just attached now (4th), it doesn't look so aligned anymore.
Basically most artifacts will have the name on 2 rows in this window, and some on 3 rows. So you can either align it as such, that the artifact icon together with 2 rows of name are centered horizontally as compared to the morale icon, or, preferably, align at the top (the morale icon with the artifact > just as in 0.82).
|
|
|
|
(0001621)
|
|
Ivan
|
|
2011-03-04 14:03
|
|
Currently we have: align all images at the center and draw subtitle just below them, only image height is used for alignment
Your proposition (0.82 behavior): same, but use image height + subtitle height for alignment - this results in 0000190
We can also align images at the top but I don't think that this solution will look better than current one. |
|
|
|
(0001624)
|
|
Zamolxis
|
2011-03-04 15:31
(edited on: 2011-03-07 11:19) |
|
We don't have the screenshot for 0000190 anymore and I don't remember what the problem was there exactly. If it was the fact that the subtitle was affecting the vertical alignment of the icon above it, than that is not what I am asking.
What I am asking is to align using image height (only), but not take the center of the image as reference point (as now), but the top of the image (as you can see in the 2nd screenshot here: coincidence or not, the most upper pixel of the Blackshard of the Dead Knight seems to be at the same level with the most upper pixels of the bad morale icon, and it looks good).
This will also take care that if one day we have some custom artifacts with longer name (hypothetical example: "Poisoned Blackshard of the Dead Knight") which would take up 4 rows of subtitle, we don't end up overlapping the checkbox like the 1st screenshot from this report. EDIT: I just saw you implemented a solution for 4-rows subtitles in this window (Bowstring of the Unicorns's Mane), that is enlarge the window on the vertical. This solves the overlapping problem, but IMO just doesn't look good (0000704).
|
|
|
|
(0001660)
|
|
Ivan
|
|
2011-03-19 15:13
|
|
|
Made some tweaks, uploaded resulting image. Are you proposing something like this? |
|
|
|
|
|
@Ivan: That's indeed what I had in mind. IMHO the alignment in the screenshots you made after your tweaks looks notably better. |
|
|
|
(0001664)
|
|
Ivan
|
|
2011-03-22 11:37
|
|
|
Moving to resolved then - that screenshot comes from rev 2041. |
|
2010-11-13_TombArtifactName.jpg (59,895) 2010-11-13 13:30