MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000568VCMIMechanics - Battlespublic2010-07-29 07:542010-10-27 13:27
ReporterBoulie 
Assigned ToTow 
PrioritynormalSeveritycrashReproducibilityunable to reproduce
StatusclosedResolutionunable to reproduce 
PlatformOSOS Version
Product Version0.81d 
Target VersionFixed in Version 
Summary0000568: Crash after battle and/or after visiting Learning Stone
DescriptionWhen I wast checking new Ivan's rev 1702, I got crash.
Battle Grindan vs Orrin from map attached in 559
http://bugs.vcmi.eu/file_download.php?file_id=503&type=bug, [^]
After I've chosen new skills, I got into Grindan's screen, I saw game crashed (maybe it was just after sec skills choosing). Gringan didn't got any new skills and exp.
(see screenshot and also attached crash dump files)

Steps To Reproduce
Additional InformationIs this possible to make VCMI crashhandler to appear "always on top"
It would be easier to catch right moment of crash.
TagsNo tags attached.
Relationships
Attached Filesjpg crash after gaining sec skills.jpg (201,066) 2010-07-29 07:54
https://bugs.vcmi.eu/file_download.php?file_id=516&type=bug
jpg

zip crash after gaining sec skills.zip (140,702) 2010-07-29 07:54
https://bugs.vcmi.eu/file_download.php?file_id=517&type=bug
jpg crash after get into learning stone.jpg (275,750) 2010-07-29 12:32
https://bugs.vcmi.eu/file_download.php?file_id=519&type=bug
jpg

zip crash after get into learning stone.zip (138,080) 2010-07-29 12:32
https://bugs.vcmi.eu/file_download.php?file_id=520&type=bug
zip games MP.zip (132,811) 2010-07-29 12:32
https://bugs.vcmi.eu/file_download.php?file_id=521&type=bug
? Insanity LH.h3m (23,716) 2010-07-29 12:55
https://bugs.vcmi.eu/file_download.php?file_id=522&type=bug
Issue History
Date ModifiedUsernameFieldChange
2010-07-29 07:54BoulieNew Issue
2010-07-29 07:54BoulieStatusnew => assigned
2010-07-29 07:54BoulieAssigned To => Tow dragon
2010-07-29 07:54BoulieFile Added: crash after gaining sec skills.jpg
2010-07-29 07:54BoulieFile Added: crash after gaining sec skills.zip
2010-07-29 11:01Tow dragonAssigned ToTow dragon => Ivan
2010-07-29 11:38BoulieNote Added: 0001234
2010-07-29 11:46BoulieNote Edited: 0001234bug_revision_view_page.php?bugnote_id=1234#r1043
2010-07-29 11:47BoulieNote Edited: 0001234bug_revision_view_page.php?bugnote_id=1234#r1044
2010-07-29 11:48BoulieNote Edited: 0001234bug_revision_view_page.php?bugnote_id=1234#r1045
2010-07-29 11:52BoulieNote Edited: 0001234bug_revision_view_page.php?bugnote_id=1234#r1046
2010-07-29 12:32BoulieNote Added: 0001235
2010-07-29 12:32BoulieNote Edited: 0001235bug_revision_view_page.php?bugnote_id=1235#r1048
2010-07-29 12:32BoulieFile Added: crash after get into learning stone.jpg
2010-07-29 12:32BoulieFile Added: crash after get into learning stone.zip
2010-07-29 12:32BoulieFile Added: games MP.zip
2010-07-29 12:55BoulieNote Edited: 0001235bug_revision_view_page.php?bugnote_id=1235#r1049
2010-07-29 12:55BoulieFile Added: Insanity LH.h3m
2010-07-29 18:09ZamolxisNote Added: 0001245
2010-07-29 18:09ZamolxisSummaryCrash after battle => Crash after battle and/or after visiting Learning Stone
2010-07-29 19:11IvanNote Added: 0001246
2010-07-29 19:11IvanNote Edited: 0001246bug_revision_view_page.php?bugnote_id=1246#r1053
2010-07-29 20:40IvanNote Edited: 0001246bug_revision_view_page.php?bugnote_id=1246#r1054
2010-07-29 20:44IvanNote Edited: 0001246bug_revision_view_page.php?bugnote_id=1246#r1055
2010-07-30 08:57IvanAssigned ToIvan =>
2010-07-30 08:58IvanStatusassigned => new
2010-07-30 12:01TowNote Added: 0001247
2010-07-30 12:24IvanNote Added: 0001248
2010-07-30 12:28TowNote Added: 0001249
2010-07-30 13:05TowNote Added: 0001250
2010-07-30 13:29majaczekNote Added: 0001252
2010-07-30 13:54TowNote Added: 0001253
2010-07-30 16:48majaczekNote Added: 0001254
2010-10-26 14:03WarmongerRelationship addedhas duplicate 0000628
2010-10-27 09:05WarmongerNote Added: 0001361
2010-10-27 09:05WarmongerStatusnew => resolved
2010-10-27 09:05WarmongerFixed in Version => 0.89
2010-10-27 09:05WarmongerResolutionopen => fixed
2010-10-27 09:05WarmongerAssigned To => Warmonger
2010-10-27 13:25TowRelationship deletedhas duplicate 0000628
2010-10-27 13:27TowNote Added: 0001363
2010-10-27 13:27TowAssigned ToWarmonger => Tow
2010-10-27 13:27TowStatusresolved => closed
2010-10-27 13:27TowResolutionfixed => unable to reproduce
2010-10-27 13:27TowFixed in Version0.89 =>

Notes
(0001234)
Boulie   
2010-07-29 11:38   
(edited on: 2010-07-29 11:52)
just to clarify. I played it few times later and everything was ok, also I've made some test with exp in pandora's box and it was ok, too.
So maybe it is only coincidence that it happened during checking Ivan's rev.


EDIT: One more thing. Take a look in txt log at
"System message: Server encountered a problem: There is no stack on 58 tile (no attack)!" it was during comp turn and champions attack. It happened 2 times.
It is more lass connected with http://bugs.vcmi.eu/view.php?id=560. [^]
When I played this battle in MP, I had same situation I attack 2-hex stack with 2-hex stack and attack wasn't possible cause unit couldn't be placed in right position.
"System message: Server encountered a problem: We cannot move this stack to its destination Champions"

It is included in VCMI_client_log no.2 from crashes 0000559: http://bugs.vcmi.eu/file_download.php?file_id=501&type=bug [^]

EDIT2:
And maybe, computer during champions attack, attacked AA from back. But I'm not sure about that. And I don't know if after the crash happened during battle it could be possible to choose skills and go into hero's screen? Crash handler appears in background.
(0001235)
Boulie   
2010-07-29 12:32   
(edited on: 2010-07-29 12:55)
Added new note cause this is kind of new situation in this case.
Game always crashes if I get into learning stone, in the moment when new sec skill screen should appear.
Load added game, take Gerwulf and go into learning stone near castle
(added screenshot, crash dump files and saved game in MP)

EDIT: I've just added also the map, cause on other maps there is no such a problem.
Run the map in SP and go to learning stone.
(0001245)
Zamolxis   
2010-07-29 18:09   
I updated the Summary, because following the above it seems the bug is more about visiting the Learning Stone (or are they 2 different crash bugs?... hopefully the dumps can clarify).
(0001246)
Ivan   
2010-07-29 19:11   
(edited on: 2010-07-29 20:44)
According to logs these are different crashes:

1)after selecting secondary skills
all levelups have been applied, server crashed after sending message SetSelection
Can't find anything more in the logs. Can someone look for useful info in crash dumps? Don't see a way to use them without Visual Studio

2) learning stone crash
Server crashed during level-up.
This one is weird. I have crash only with savegame - new game on this map is fine.
Crash occurs on changing primary skills - (assert failure on NetPacksLib.cpp:61)
Game can't find bonus representing hero primary skills

Possible serialization issue: values of primary skills in loaded save game are 0-0-1-1 while on 2nd screenshot we see 0-4-1-1
(0001247)
Tow   
2010-07-30 12:01   
1)
Dump is meaningless, since there is only client dump not the server one. According to the logs there should be both, so please look for VCMI_server.exe_crashinfo.dmp

2)
Same here (client says it crashes cause server crashed) but this time there is no trace of server crashdump, it must have died silently. Most likely it was that failed assertion.
(0001248)
Ivan   
2010-07-30 12:24   
>> Most likely it was that failed assertion.
It was.
You can see that error line on 2nd screenshot:
NetPacksLib.cpp:61 - assert(skill);
skill is pointer to bonus with hero primary skill. Which was not found for some reason
(0001249)
Tow   
2010-07-30 12:28   
@Ivan
1)
Server didn't crash after sending SetSelection. Look in logs for "Disaster happened". It crashed in the battle handling thread after sendind resultsApplied I guess. The connection-handling thread was probably still running for some time, before whole server died.
Very strange.
(0001250)
Tow   
2010-07-30 13:05   
2)
It's not serialization issue, it must be some kind of desync between server and client. On client we have correct values of primskills. On server for some reasons that base primskill bonuses are lost. That leads both to crash and defected save file (when saving, gamestate is taken from server only). The question is, when and why that bonuses get erased from the list.
(0001252)
majaczek   
2010-07-30 13:29   
maybe a hero with 0 Attack or 0 Defense?
if so, it makes sense that not affecting bonus was removed
(0001253)
Tow   
2010-07-30 13:54   
Hero with 0 Attack has bonus of value 0.
(0001254)
majaczek   
2010-07-30 16:48   
but bonus handler could filter the bonus due to teoretical meaning nothing, because it doesn't know elsewhere is needed?
(0001361)
Warmonger   
2010-10-27 09:05   
Most likely fixed in r1827
(0001363)
Tow   
2010-10-27 13:27   
This issue doesn't have anything to do with r1827 (especially since problem is from 0.81d), however since it's old and not reproducible I'll close it for now.