MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000292VCMIMechanics - Battlespublic2009-12-04 11:292010-07-21 16:41
ReporterBoulie 
Assigned ToTow dragon 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version0.75 
Target VersionFixed in Version0.8 
Summary0000292: Spells with orb +50% dmg are wrongly calculated
DescriptionSee screenshots
i.e.
Magic arrow with orb +50% dmg is calculated as. (SPx10+10)x100+50%(SPx10+10)
so magic arrow of hero wih SP 10 and orb(50%) has dmg 11055.
similar situation is with all other damaging spell.
But if the dmgs are more then 99999 the dmg are a little bit changed
so i.e. Implosion with SP 10 inflict 850 dmg with orb it should be 850+425=1275 dmg, Now it is like 85x1000 + 425=85425.
Steps To ReproduceYou can check it with added test map and hero Christian (first need to equip the orbs from backpack)
Additional Information
TagsNo tags attached.
Relationships
Attached Files? test.h3m (9,815) 2009-12-04 11:29
https://bugs.vcmi.eu/file_download.php?file_id=153&type=bug
jpg spell-magic arrow-does 11k dmg with 10 SP.jpg (499,600) 2009-12-04 11:29
https://bugs.vcmi.eu/file_download.php?file_id=154&type=bug
jpg

jpg spell-ice bolt-does 21k dmg with 10 SP.jpg (405,052) 2009-12-04 11:29
https://bugs.vcmi.eu/file_download.php?file_id=155&type=bug
jpg

jpg spell-armageddon-does 53k dmg with 10 SP.jpg (436,848) 2009-12-04 11:29
https://bugs.vcmi.eu/file_download.php?file_id=156&type=bug
jpg

jpg spell-implosion-does 85k dmg with 10 SP.jpg (447,890) 2009-12-04 11:29
https://bugs.vcmi.eu/file_download.php?file_id=157&type=bug
jpg
Issue History
Date ModifiedUsernameFieldChange
2009-12-04 11:29BoulieNew Issue
2009-12-04 11:29BoulieFile Added: test.h3m
2009-12-04 11:29BoulieFile Added: spell-magic arrow-does 11k dmg with 10 SP.jpg
2009-12-04 11:29BoulieFile Added: spell-ice bolt-does 21k dmg with 10 SP.jpg
2009-12-04 11:29BoulieFile Added: spell-armageddon-does 53k dmg with 10 SP.jpg
2009-12-04 11:29BoulieFile Added: spell-implosion-does 85k dmg with 10 SP.jpg
2009-12-04 12:23BoulieNote Added: 0000378
2009-12-04 20:24majaczekNote Added: 0000380
2010-01-30 16:48Tow dragonNote Added: 0000597
2010-01-30 16:48Tow dragonStatusassigned => resolved
2010-01-30 16:48Tow dragonFixed in Version => 0.89
2010-01-30 16:48Tow dragonResolutionopen => fixed
2010-07-21 16:41ZamolxisNote Added: 0001155
2010-07-21 16:41ZamolxisStatusresolved => closed

Notes
(0000378)
Boulie   
2009-12-04 12:23   
ofc additional info about bigger dmgs is stupid. Don't even read it ;)
All spells with orbs are calculated in the same way:
dmg x 100+50% dmg
(0000380)
majaczek   
2009-12-04 20:24   
i think its a mistake (x100 instead x100%) so it should be damage*(100+50)/100 (where 50 is count of bonus percent)
(0000597)
Tow dragon   
2010-01-30 16:48   
fixed in rev 1436
(0001155)
Zamolxis   
2010-07-21 16:41   
Verified on a couple of spells as working correctly in 0.81. Please reopen if you still find scenarios in which the orb bonus is applied incorrectly.