MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002430VCMIModspublic2016-03-20 10:422022-04-12 11:19
Reportermisiokles 
Assigned ToDydzio 
PriorityhighSeverityfeatureReproducibilityalways
StatusclosedResolutionfixed 
PlatformPCOSWindowsOS Version10
Product Version0.98g 
Target VersionFixed in Version 
Summary0002430: Commanders stop gain experience from the battle
DescriptionCommanders seem to gain experience only from Learning Stones in 0.98g.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-03-20 10:42misioklesNew Issue
2016-03-20 18:07anonymousStatusnew => feedback
2016-03-21 17:30AVSStatusfeedback => new
2016-09-30 21:52DydzioNote Added: 0006788
2016-09-30 21:52DydzioAssigned To => Dydzio
2016-09-30 21:52DydzioStatusnew => assigned
2016-09-30 21:53DydzioStatusassigned => feedback
2016-10-01 02:29AVSNote Added: 0006789
2016-10-01 07:15WarmongerNote Added: 0006790
2016-10-01 08:56DydzioStatusfeedback => assigned
2016-10-01 15:25DydzioNote Added: 0006797
2016-10-01 16:12DydzioNote Edited: 0006797bug_revision_view_page.php?bugnote_id=6797#r3255
2016-10-01 16:24DydzioNote Edited: 0006797bug_revision_view_page.php?bugnote_id=6797#r3256
2016-10-03 06:21misioklesNote Added: 0006809
2016-10-03 11:03DydzioNote Added: 0006810
2016-10-03 11:03DydzioStatusassigned => resolved
2016-10-03 11:03DydzioResolutionopen => fixed
2022-04-12 11:19PovelitelStatusresolved => closed

Notes
(0006788)
Dydzio   
2016-09-30 21:52   
Can anybody tell more about commander experience mechanics? When is it granted, how much, are there any factors that can modify experience multiplier etc.?
(0006789)
AVS   
2016-10-01 02:29   
For now commander should receive same exp as hero.
(0006790)
Warmonger   
2016-10-01 07:15   
Castle Commander has permanent +50% experience gain bonus.
(0006797)
Dydzio   
2016-10-01 15:25   
(edited on: 2016-10-01 16:24)
EDIT: CGameHandler code "kills" commander via battle casualties procedure at end of each battle, moreover if commander really dies practically nothing changes - he still appears in battles.
(0006809)
misiokles   
2016-10-03 06:21   
All about WoG's commanders (VCMI commanders are lighter version) are descripe here: http://www.celestialheavens.com/h3maparchives/wog/wogfeatures.html [^]

And please, don't forget about this bug:
http://bugs.vcmi.eu/view.php?id=2439 [^]
(0006810)
Dydzio   
2016-10-03 11:03   
Fixed in: https://github.com/vcmi/vcmi/pull/230 [^] and https://github.com/vcmi/vcmi/commit/723734fd04655ec456fb52154073b54e29e759d7 [^]

Extra experience for castle commander not added, as it may be better idea to implement it later via unified commander specialty system. Generally commander code needs more attention, many things are missing for example descriptions for skills or commander revival requirements. For now commander "just works".