MantisBT - VCMI
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001743VCMIMechanics - Objectspublic2014-03-03 18:512014-06-02 09:38
Reporterbeegee 
Assigned Tobeegee 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version0.95b 
Summary0001743: Hero does not have increased primary skill level according to experience
DescriptionHero with level 25 and a lot of experience still has starting primary skill levels. Primary skill levels should be adapted to experience amount like in OH3.

I wonder why no one has ever noticed this:)
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-03-03 18:51beegeeNew Issue
2014-03-03 18:51beegeeStatusnew => assigned
2014-03-03 18:51beegeeAssigned To => Warmonger
2014-03-03 18:56WarmongerNote Added: 0004569
2014-03-03 19:04beegeeNote Added: 0004570
2014-03-03 19:06beegeeNote Edited: 0004570bug_revision_view_page.php?bugnote_id=4570#r2543
2014-03-03 19:24beegeeNote Added: 0004571
2014-03-03 19:24beegeeNote Edited: 0004571bug_revision_view_page.php?bugnote_id=4571#r2545
2014-03-05 17:55beegeeAssigned ToWarmonger => beegee
2014-03-06 08:41TowNote Added: 0004574
2014-03-06 09:38WarmongerNote Added: 0004575
2014-04-10 17:30beegeeNote Added: 0004632
2014-04-10 17:30beegeeStatusassigned => resolved
2014-04-10 17:30beegeeFixed in Version => 0.95b
2014-04-10 17:30beegeeResolutionopen => fixed
2014-06-02 09:38KantorNote Added: 0004715
2014-06-02 09:38KantorStatusresolved => closed

Notes
(0004569)
Warmonger   
2014-03-03 18:56   
How to reproduce this bug? Do you mean campaign only?
(0004570)
beegee   
2014-03-03 19:04   
(edited on: 2014-03-03 19:06)
Problem is that whole logic resides in CGameHandler on the server side. It would be best if level up logic would be somewhere in CGHeroInstance. So I can't quickly fix this.

How to reproduce this bug? Do you mean campaign only?
>> It affects both campaigns and normal maps.
(0004571)
beegee   
2014-03-03 19:24   
Tow, can I move some of the level up handling (selection of primary skill) to CGHeroInstance (lib)?
Just in the case that's it's really a bug.
(0004574)
Tow   
2014-03-06 08:41   
@beegee
Yes, it is ok to move game logic to lib.
I haven't checked this but AFAIR the issue is not specific to campaigns — if I have set hero exp/level but have not touched his skills, he should have them upped according to the level. And I think it also worked for the secondary skills.
(0004575)
Warmonger   
2014-03-06 09:38   
Most certainly auto-leveling heroes worked for heroes in prisons.
(0004632)
beegee   
2014-04-10 17:30   
Fixed in rev 1d57b75bc5a6347e4e6dd349785493b204601410

Auto-leveling works for heroes and heroes in prisons. Primary and secondary skills are updated according to hero level. Secondary skill selection implemented as in OH3, learned skills are upgraded first then new skills are chosen.
(0004715)
Kantor   
2014-06-02 09:38   
This one may be closed.